Don't link with libgadu unnecessarily

Review Request #2684 — Created Oct. 24, 2023 and submitted

Information

pidgin/pidgin
release-2.x.y

Reviewers

The default if-found action of AC_CHECK_LIB is to add the library to LIBS,
but that means it's used for all linking. So a GPL-compliant libgadu gets
linked with libpurple, finch, pidgin, and all plugins instead of just the
protocol plugin.

Compiled and checked that there was no libgadu.so in ldd libpurple.so and a few other built things, but it was still there for the Gadu-Gadu protocol plugin.

Summary ID
Don't link with libgadu unnecessarily
The default if-found action of `AC_CHECK_LIB` is to add the library to `LIBS`, but that means it's used for _all_ linking. So a GPL-compliant libgadu gets linked with libpurple, finch, pidgin, and all plugins instead of just the protocol plugin.
0f5d42c7391f72f8afadc3175b677a44bbdc0743
grim
  1. Nice find, thanks!!

  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...