Summary

IRCv3: Implement the channel joining functions in PurpleProtocolConversation

Review Request #2678 — Created Oct. 20, 2023 and submitted Oct. 20, 2023, 7:17 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2672~~

Reviewers

Groups

pidgin

People

Description

I tested this on libera and twitch and was able to join channels and send
messages on both.

Testing Done

As mentioned earlier tested on libera and twitch. I ran into some additional issues with twitch which these changes exposed but aren't caused by these changes.

Commits

Summary	ID
IRCv3: Implement the channel joining functions in PurpleProtocolConversation I tested this on libera and twitch and was able to join channels and send messages on both.	f3b8e2dae821861acee13057e102e033fdbb9dff

Issues

Description	From	Last Updated
Do we need to do any escaping of, e.g., colon, or check for spaces or the like? Or do we …	QuLogic	Oct. 20, 2023, 7:03 a.m.
Do we plan to wait for the server to acknowledge, or will e.g., join failures go in this conversation?	QuLogic	Oct. 20, 2023, 7:03 a.m.

libpurple/protocols/ircv3/purpleircv3protocolconversation.c (Diff revision 1)

The issue has been dropped. Show all issues

Do we need to do any escaping of, e.g., colon, or check for spaces or the like? Or do we leave it for the server?

grim Oct. 20, 2023, 6:18 a.m.

We probably should validate but the server will validate for us right now.

libpurple/protocols/ircv3/purpleircv3protocolconversation.c (Diff revision 1)

The issue has been dropped. Show all issues

Do we plan to wait for the server to acknowledge, or will e.g., join failures go in this conversation?

grim Oct. 20, 2023, 6:18 a.m.

Yeah this is just a stop gap for the moment. Some servers will send a join message back with the source set to us, other's send a specific reply and so on. This just lets us get the core working and we can come back and fix those cases later.

Ship it!

```
Ship It!
```

Status:: Completed