Summary: |
|
|---|
Create a new PidginChannelJoinDialog widget
Review Request #2672 — Created Oct. 17, 2023 and submitted
This works with PurpleProtocolConversation using get_channel_join_details, join_channel_async, and join_channel_finish.
Used a half finished implementation in IRCv3 of the join channel functions in
PurplProtocolConversationfor testing.
Change Summary:
rebase and break a reference loop
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1202 -4) |
Change Summary:
Only create the cancellable when the
Joinbutton is pressed and don't add a reference to the dialog for the cancellable as the dialog is controlling the lifecycle of the cancellable.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1184 -4) |
-
-
pidgin/pidginchanneljoindialog.c (Diff revision 3) Should every entry be disabled during the join operation as well?
-
pidgin/resources/channeljoindialog.ui (Diff revision 3) IIRC, these
requiresdo nothing, but this file is part of Pidgin, so it doesn't make sense to require itself?
Change Summary:
rebase and address issues.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1196 -4) |