Create a new PidginChannelJoinDialog widget

Review Request #2672 — Created Oct. 17, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This works with PurpleProtocolConversation using get_channel_join_details,
join_channel_async, and join_channel_finish.

Used a half finished implementation in IRCv3 of the join channel functions in PurplProtocolConversation for testing.

Summary ID
Create a new PidginChannelJoinDialog
This works with PurpleProtocolConversation using get_channel_join_details, join_channel_async, and join_channel_finish.
5f03978d52e785283db2dc4d60816fdb27f02220
Description From Last Updated

Should every entry be disabled during the join operation as well?

QuLogicQuLogic

IIRC, these requires do nothing, but this file is part of Pidgin, so it doesn't make sense to require itself?

QuLogicQuLogic
grim
grim
grim
QuLogic
  1. 
      
  2. pidgin/pidginchanneljoindialog.c (Diff revision 3)
     
     
    Show all issues

    Should every entry be disabled during the join operation as well?

    1. Totally didn't think of this either. I think I can just make the preference group insenstive though to accomplish that.

  3. pidgin/resources/channeljoindialog.ui (Diff revision 3)
     
     
    Show all issues

    IIRC, these requires do nothing, but this file is part of Pidgin, so it doesn't make sense to require itself?

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed