- Summary:
-
Create a new PidginChannelJoinDialogCreate a new PidginChannelJoinDialog widget
Create a new PidginChannelJoinDialog widget
Review Request #2672 — Created Oct. 17, 2023 and submitted
This works with PurpleProtocolConversation using get_channel_join_details, join_channel_async, and join_channel_finish.
Used a half finished implementation in IRCv3 of the join channel functions in
PurplProtocolConversationfor testing.
- Change Summary:
-
rebase and break a reference loop
- Commits:
-
Summary ID 055aecbdaef18b621321e093f52a1f2a2c8dae04 d22c9693c0de4cd1e96717ddc9a16fd54592b7e2
- Change Summary:
-
Only create the cancellable when the
Joinbutton is pressed and don't add a reference to the dialog for the cancellable as the dialog is controlling the lifecycle of the cancellable. - Commits:
-
Summary ID d22c9693c0de4cd1e96717ddc9a16fd54592b7e2 97b2760b16460854f3bfff364813416c06e59c5f
