-
-
libpurple/plugins/kwallet/purplekwallet.cpp (Diff revision 1) We should probably switch the
purple_debug
functions to the GLib loggers.
fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore
Review Request #2648 — Created Oct. 12, 2023 and submitted
fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore
Due to changes in r/2338 running Pidgin in broadway resulted in following error:
plugins-Message: 00:30:55.180: Auto-loading plugin /home/grim/p/pidgin/build/libpurple/plugins/kwallet/purplekwallet.so qt.qpa.xcb: could not connect to display qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found. This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem. Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb. Aborted (core dumped)
So this patch reverts back to QCoreApplication. To deal with the runtime warning r/2338 was trying to solve, we now install a message handler that puts the Qt warnings and other messages into Pidgin's debug window.
- ran Pidgin3 using broadway as GDK_BACKEND
- checked that the kwallet warning ("Cannot use KWindowSystem without a QGuiApplication") appeared in the debug window when switching credential manager to kwallet
Change Summary:
Used GLib loggers for the message handler and replaced other
purple_debug_*
s with GLib loggers. Fixed build options so G_LOG_DOMAIN is set properly.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+96 -50) |
-
-
libpurple/plugins/kwallet/purplekwallet.cpp (Diff revisions 1 - 2) I'm not sure about this one; it's a true mapping of intent, but I wonder if we do want it to be fatal if it's in a plugin.
Change Summary:
addressed issue regarding "fatal" log level
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+100 -50) |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+100 -50) |