fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore

Review Request #2648 — Created Oct. 12, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore

Due to changes in r/2338 running Pidgin in broadway resulted in following error:

plugins-Message: 00:30:55.180: Auto-loading plugin /home/grim/p/pidgin/build/libpurple/plugins/kwallet/purplekwallet.so
qt.qpa.xcb: could not connect to display 
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb.

Aborted (core dumped)

So this patch reverts back to QCoreApplication. To deal with the runtime warning r/2338 was trying to solve, we now install a message handler that puts the Qt warnings and other messages into Pidgin's debug window.

  • ran Pidgin3 using broadway as GDK_BACKEND
  • checked that the kwallet warning ("Cannot use KWindowSystem without a QGuiApplication") appeared in the debug window when switching credential manager to kwallet
Summary ID
fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore
eb54247f604827b75b84306fd2992918cf59e8de
Description From Last Updated

We should probably switch the purple_debug functions to the GLib loggers.

QuLogicQuLogic

I'm not sure about this one; it's a true mapping of intent, but I wonder if we do want it …

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/plugins/kwallet/purplekwallet.cpp (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    We should probably switch the purple_debug functions to the GLib loggers.

  3. 
      
ivanhoe
QuLogic
  1. 
      
  2. libpurple/plugins/kwallet/purplekwallet.cpp (Diff revisions 1 - 2)
     
     
     
     
     
    Show all issues

    I'm not sure about this one; it's a true mapping of intent, but I wonder if we do want it to be fatal if it's in a plugin.

  3. 
      
ivanhoe
QuLogic
  1. All looks reasonable, but you may want to rebase it.

    1. In case you don't know how to rebase

      • pull in remote changes
      • update to your branch
      • hg rebase -d default --keepbranches

      You're most likely going to run into merge conflicts. Fix them, then use hg resolve --mark to mark them as fixed. When you've gotten all of them hg will tell you to hg rebase --continue but you can also view the status with hg resolve --list.

  2. 
      
ivanhoe
grim
  1. Great work! Thanks for figuring this out and making sure it landed!!

  2. 
      
grim
Review request changed
Status:
Completed