Summary

fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore

Review Request #2648 — Created Oct. 12, 2023 and submitted Oct. 20, 2023, 12:51 a.m.

Information

Owner

ivanhoe

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore

Due to changes in r/2338 running Pidgin in broadway resulted in following error:

plugins-Message: 00:30:55.180: Auto-loading plugin /home/grim/p/pidgin/build/libpurple/plugins/kwallet/purplekwallet.so
qt.qpa.xcb: could not connect to display 
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb.

Aborted (core dumped)

So this patch reverts back to QCoreApplication. To deal with the runtime warning r/2338 was trying to solve, we now install a message handler that puts the Qt warnings and other messages into Pidgin's debug window.

Testing Done


ran Pidgin3 using broadway as GDK_BACKEND
checked that the kwallet warning ("Cannot use KWindowSystem without a QGuiApplication") appeared in the debug window when switching credential manager to kwallet

Commits

Summary	ID
fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore	eb54247f604827b75b84306fd2992918cf59e8de

Issues

Description	From	Last Updated
We should probably switch the purple_debug functions to the GLib loggers.	QuLogic	Oct. 20, 2023, 12:11 a.m.
I'm not sure about this one; it's a true mapping of intent, but I wonder if we do want it …	QuLogic	Oct. 20, 2023, 12:11 a.m.

libpurple/plugins/kwallet/purplekwallet.cpp (Diff revision 1)

The issue has been resolved. Show all issues

We should probably switch the purple_debug functions to the GLib loggers.

Change Summary:

Used GLib loggers for the message handler and replaced other purple_debug_*s with GLib loggers. Fixed build options so G_LOG_DOMAIN is set properly.

Commits:

	Summary	ID
	fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore	0e2bfc259cebdec901294a5a552dd31111929d00
	fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore	dc39c7c6d7ea7101798f750472a400ecf53a0b3a

Diff:

Revision 2 (+96 -50)

Show changes

	meson.build
	libpurple/plugins/kwallet/meson.build
	libpurple/plugins/kwallet/purplekwallet.cpp

libpurple/plugins/kwallet/purplekwallet.cpp (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

I'm not sure about this one; it's a true mapping of intent, but I wonder if we do want it to be fatal if it's in a plugin.

Change Summary:

addressed issue regarding "fatal" log level

Commits:

	Summary	ID
	fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore	dc39c7c6d7ea7101798f750472a400ecf53a0b3a
	fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore	ff16cef96dbf136c23bde7af4ccacf21385c509d

Diff:

Revision 3 (+100 -50)

Show changes

	meson.build
	libpurple/plugins/kwallet/meson.build
	libpurple/plugins/kwallet/purplekwallet.cpp

Ship it!

All looks reasonable, but you may want to rebase it.

grim Oct. 20, 2023, 12:31 a.m.

In case you don't know how to rebase

pull in remote changes
update to your branch
hg rebase -d default --keepbranches

You're most likely going to run into merge conflicts. Fix them, then use hg resolve --mark to mark them as fixed. When you've gotten all of them hg will tell you to hg rebase --continue but you can also view the status with hg resolve --list.

Change Summary:

rebased

Commits:

	Summary	ID
	fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore	ff16cef96dbf136c23bde7af4ccacf21385c509d
	fix problem that Pidgin3 couldn't be run using broadway GDK_BACKEND anymore	eb54247f604827b75b84306fd2992918cf59e8de

Diff:

Revision 4 (+100 -50)

Show changes

	meson.build
	libpurple/plugins/kwallet/meson.build
	libpurple/plugins/kwallet/purplekwallet.cpp

Ship it!

Great work! Thanks for figuring this out and making sure it landed!!

Status:: Completed