Move PidginAvatar to a single resource file

Review Request #2646 — Created Oct. 12, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Move PidginAvatar to a single resource file

Ran and verified the menu still worked.

Summary ID
Move PidginAvatar to a single resource file
a06e946d4aa0420bbfeceb165d477e21a230831e
Description From Last Updated

model is maybe a bit ambiguous, as one wouldn't know it's the menu model; leaving it as menu might be …

QuLogicQuLogic

Don't we still keep each widget's files in a subdirectory even if there's only one?

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/resources/avatar.ui (Diff revision 1)
     
     
    Show all issues

    model is maybe a bit ambiguous, as one wouldn't know it's the menu model; leaving it as menu might be better.

  3. pidgin/resources/pidgin.gresource.xml (Diff revision 1)
     
     
    Show all issues

    Don't we still keep each widget's files in a subdirectory even if there's only one?

    1. There's a few that aren't and I feel like a directory with a single file is over kill and it seems that gtk does everything in one directory... So I dunno?

    2. Good enough reason, I guess.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed