Summary

Move PidginAvatar to a single resource file

Review Request #2646 — Created Oct. 12, 2023 and submitted Oct. 13, 2023, 3:57 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Move PidginAvatar to a single resource file

Testing Done

Ran and verified the menu still worked.

Commits

Summary	ID
Move PidginAvatar to a single resource file	a06e946d4aa0420bbfeceb165d477e21a230831e

Issues

Description	From	Last Updated
model is maybe a bit ambiguous, as one wouldn't know it's the menu model; leaving it as menu might be …	QuLogic	Oct. 13, 2023, 3:48 a.m.
Don't we still keep each widget's files in a subdirectory even if there's only one?	QuLogic	Oct. 13, 2023, 3:48 a.m.

pidgin/resources/avatar.ui (Diff revision 1)

Show all issues

model is maybe a bit ambiguous, as one wouldn't know it's the menu model; leaving it as menu might be better.

grim Oct. 13, 2023, 3:19 a.m.
```
good call.
```

pidgin/resources/pidgin.gresource.xml (Diff revision 1)

Show all issues

Don't we still keep each widget's files in a subdirectory even if there's only one?

grim Oct. 13, 2023, 3:19 a.m.

There's a few that aren't and I feel like a directory with a single file is over kill and it seems that gtk does everything in one directory... So I dunno?

QuLogic Oct. 13, 2023, 3:48 a.m.
```
Good enough reason, I guess.
```

Change Summary:

rebased and renamed model to menu

Commits:

	Summary	ID
	Move PidginAvatar to a single resource file	286d85ca051cc4dbfd9839e4b6ed2a050246b844
	Move PidginAvatar to a single resource file	a06e946d4aa0420bbfeceb165d477e21a230831e

Diff:

Revision 2 (+48 -124)

Show changes

	pidgin/pidginavatar.c
	pidgin/resources/Avatar/avatar.ui
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Avatar/menu.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```

Review Board 6.0.2