Summary

Implement ProtocolFileTransfer

Review Request #2643 — Created Oct. 10, 2023 and submitted Oct. 20, 2023, 6:12 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17833

Depends On

Reviewers

Groups

pidgin

People

Description

Implement ProtocolFileTransfer

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Implement ProtocolFileTransfer	4abb69c8cbbed24d9f44898ea468ed440c31a06b

Issues

Description	From	Last Updated
Weird indent.	QuLogic	Oct. 20, 2023, 5:55 a.m.

Ship it!

```
Ship It!
```
libpurple/purpleprotocolfiletransfer.h (Diff revision 1)
Show all issues
```
Weird indent.
```

Change Summary:

fix indents

Commits:

	Summary	ID
	Implement ProtocolFileTransfer	1f815ec7d5102792ffe8c12a34783286b190ac75
	Implement ProtocolFileTransfer	9daeb32e9b364986b9aa1edc19dcd5ddd7b198d5

Diff:

Revision 2 (+1662)

Show changes

	libpurple/meson.build
	libpurple/purplefiletransfer.h
	libpurple/purpleprotocolfiletransfer.h
	libpurple/purpleprotocolfiletransfer.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_file_transfer.c

Change Summary:

rebased and fixed the account include.

Commits:

	Summary	ID
	Implement ProtocolFileTransfer	9daeb32e9b364986b9aa1edc19dcd5ddd7b198d5
	Implement ProtocolFileTransfer	4abb69c8cbbed24d9f44898ea468ed440c31a06b

Diff:

Revision 3 (+1662)

Show changes

	libpurple/meson.build
	libpurple/purplefiletransfer.h
	libpurple/purpleprotocolfiletransfer.h
	libpurple/purpleprotocolfiletransfer.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_file_transfer.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Implement ProtocolFileTransfer

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)