Summary

Implement PurplePresenceManager

Review Request #2629 — Created Oct. 6, 2023 and submitted Oct. 24, 2023, 3:37 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17799

Depends On

Reviewers

Groups

pidgin

People

Description

This is just the implementation and does not yet have a _get_default function
as I want to change the way that works for managers that have persistent data,
but this change is already too big.

Testing Done

Ran the unit tests under valgrind without issue.

Commits

Summary	ID
Implement PurplePresenceManager This is just the implementation and does not yet have a _get_default function as I want to change the way that works for managers that have persistent data, but this change is already too big.	eb4660cc43da785365c122de4c10710a1c175065

Issues

Description	From	Last Updated
s/;/./	QuLogic	Oct. 24, 2023, 3:32 a.m.
This is missing the list model signal emission, g_list_model_items_changed.	QuLogic	Oct. 24, 2023, 3:32 a.m.
This duplicates lines 269-271?	QuLogic	Oct. 24, 2023, 3:33 a.m.
Two colons for signals.	QuLogic	Oct. 24, 2023, 3:33 a.m.
Ditto.	QuLogic	Oct. 24, 2023, 3:33 a.m.
Missing the list model signal.	QuLogic	Oct. 24, 2023, 3:33 a.m.
No tests for the signals in here?	QuLogic	Oct. 24, 2023, 3:33 a.m.

Change Summary:

rebased and fixed some include issues.

Commits:

	Summary	ID
	Implement PurplePresenceManager This is just the implementation and does not yet have a _get_default function as I want to change the way that works for managers that have persistent data, but this change is already too big.	c93827fc6dcf2ad106cdd97a5282d1433e70fd63
	Implement PurplePresenceManager This is just the implementation and does not yet have a _get_default function as I want to change the way that works for managers that have persistent data, but this change is already too big.	96352704082d2a0e1b4b1324da8e6d644711bf33

Diff:

Revision 2 (+1854 -6)

Show changes

	libpurple/meson.build
	libpurple/purplepresencemanager.h
	libpurple/purplepresencemanager.c
	libpurple/purplesavedpresence.c
	libpurple/purplesavedpresenceprivate.h
	libpurple/data/im.pidgin.Purple.PresenceManager.gschema.xml
	libpurple/tests/meson.build
	libpurple/tests/test_presence_manager.c

Change Summary:

rebased

Commits:

	Summary	ID
	Implement PurplePresenceManager This is just the implementation and does not yet have a _get_default function as I want to change the way that works for managers that have persistent data, but this change is already too big.	96352704082d2a0e1b4b1324da8e6d644711bf33
	Implement PurplePresenceManager This is just the implementation and does not yet have a _get_default function as I want to change the way that works for managers that have persistent data, but this change is already too big.	449d49ef1c5aea35eab28622d6c65c91e15b9908

Diff:

Revision 3 (+1854 -6)

Show changes

	libpurple/meson.build
	libpurple/purplepresencemanager.h
	libpurple/purplepresencemanager.c
	libpurple/purplesavedpresence.c
	libpurple/purplesavedpresenceprivate.h
	libpurple/data/im.pidgin.Purple.PresenceManager.gschema.xml
	libpurple/tests/meson.build
	libpurple/tests/test_presence_manager.c

libpurple/purplepresencemanager.h (Diff revision 3)
Show all issues
```
s/;/./
```

libpurple/purplepresencemanager.c (Diff revision 3)

Show all issues

This is missing the list model signal emission, g_list_model_items_changed.

libpurple/purplepresencemanager.c (Diff revision 3)
Show all issues
```
This duplicates lines 269-271?
```
libpurple/purplepresencemanager.c (Diff revision 3)
Show all issues
```
Two colons for signals.
```
libpurple/purplepresencemanager.c (Diff revision 3)
Show all issues
```
Ditto.
```
libpurple/purplepresencemanager.c (Diff revision 3)
Show all issues
```
Missing the list model signal.
```
libpurple/tests/test_presence_manager.c (Diff revision 3)
Show all issues
```
No tests for the signals in here?
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Implement PurplePresenceManager This is just the implementation and does not yet have a _get_default function as I want to change the way that works for managers that have persistent data, but this change is already too big.	449d49ef1c5aea35eab28622d6c65c91e15b9908
	Implement PurplePresenceManager This is just the implementation and does not yet have a _get_default function as I want to change the way that works for managers that have persistent data, but this change is already too big.	eb4660cc43da785365c122de4c10710a1c175065

Diff:

Revision 4 (+1932 -2)

Show changes

	libpurple/meson.build
	libpurple/purplepresencemanager.h
	libpurple/purplepresencemanager.c
	libpurple/purplesavedpresence.c
	libpurple/purplesavedpresenceprivate.h
	libpurple/data/im.pidgin.Purple.PresenceManager.gschema.xml
	libpurple/tests/meson.build
	libpurple/tests/test_presence_manager.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Implement PurplePresenceManager

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)