Summary

Port PidginAvatar to GtkFileDialog

Review Request #2627 — Created Sept. 26, 2023 and submitted Oct. 6, 2023, 5:57 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

GtkFileChooserNative was deprecated in 4.10 and replaced by GtkFileDialog.

Testing Done

Set a custom avatar for someone and downloaded an avatar successfully.

Commits

Summary	ID
Port PidginAvatar to GtkFileDialog GtkFileChooserNative was deprecated in 4.10 and replaced by GtkFileDialog.	ab26c54b216428c3eb1db2e842037fc30f6cb88a

Issues

Description	From	Last Updated
failed to select	QuLogic	Oct. 6, 2023, 5:49 a.m.
Can change to char.	QuLogic	Oct. 6, 2023, 5:49 a.m.
I believe this is the default for gtk_file_dialog_save.	QuLogic	Oct. 6, 2023, 5:50 a.m.
I think we determined on Discord that dialog should be unref'd here.	QuLogic	Oct. 6, 2023, 5:50 a.m.

pidgin/pidginavatar.c (Diff revision 1)
The issue has been resolved. Show all issues
```
failed to select
```
pidgin/pidginavatar.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Can change to char.
```
pidgin/pidginavatar.c (Diff revision 1)
The issue has been resolved. Show all issues
```
I believe this is the default for gtk_file_dialog_save.
```

pidgin/pidginavatar.c (Diff revision 1)

The issue has been resolved. Show all issues

I think we determined on Discord that dialog should be unref'd here.

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Port PidginAvatar to GtkFileDialog GtkFileChooserNative was deprecated in 4.10 and replaced by GtkFileDialog.	cd8dd1e17a92af8fbdf54f198522024fae94199c
	Port PidginAvatar to GtkFileDialog GtkFileChooserNative was deprecated in 4.10 and replaced by GtkFileDialog.	ab26c54b216428c3eb1db2e842037fc30f6cb88a

Diff:

Revision 2 (+114 -98)

Ship it!