Add a native-file for building against stock homebrew on macOS

Review Request #2626 — Created Sept. 25, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Add a native-file for building against stock homebrew on macOS

Compiled against both of my mac's running Monterey (12.7).
Verified the dependencies on a fresh homebrew install.

Summary ID
Add a native-file for building against stock homebrew on macOS
9e7eb967cc7667203c33f9522ce0fcfc69f3bd61
Description From Last Updated

Not 3?

QuLogicQuLogic

Shouldn't this list explicitly include at least libxml2 and icu since those are added to the pkg_config_path in homebrew.ini? Maybe …

ivanhoeivanhoe
QuLogic
  1. 
      
  2. scripts/homebrew.ini (Diff revision 1)
     
     
    1. derp, yeah it should be 3 but for some reason i was thinking 2... but it built and ran which is weird.. either way.. fixing.

  3. 
      
grim
ivanhoe
  1. 
      
  2. scripts/README.md (Diff revision 2)
     
     

    Shouldn't this list explicitly include at least libxml2 and icu since those are added to the pkg_config_path in homebrew.ini? Maybe also python3 but with meson (also not in the list) installed I guess this is a given.

    1. Both are dependencies of our dependencies. Python is required by meson which should be in the list, and libxml2 is a dependency of gtk4. So we could explicitly add them, but we don't need to. I'd personally rather keep the list smaller but I also don't really care.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...