Implement PurpleFileTransfer

Review Request #2625 — Created Sept. 25, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This initial implementation only implements the properties and defines the
basic flow. This does not actually implement any of the actual behavior as
that'll be done later when we can implement the whole thing.

Ran the unittests under valgrind.

Summary ID
Implement PurpleFileTransfer
This initial implementation only implements the properties and defines the basic flow. This does not actually implement any of the actual behavior as that'll be done later when we can implement the whole thing.
691d77a345e11d72c1971cd83b12a5eec3761ae9
Description From Last Updated

s/whose/who's

ivanhoeivanhoe

s/an/a

ivanhoeivanhoe

The enum is PURPLE_FILE_TRANSFER_STATE_FAILED without CANCELLED.

ivanhoeivanhoe

s/receieve/receive

ivanhoeivanhoe

Should the 2nd transfer be prefixed with an @?

ivanhoeivanhoe

missing a or the before protocol plugin?

ivanhoeivanhoe

Having both of the transfer and for this transfer seems superfluous.

ivanhoeivanhoe
ivanhoe
  1. 
      
  2. libpurple/purplefiletransfer.h (Diff revision 1)
     
     
    Show all issues

    s/whose/who's

  3. libpurple/purplefiletransfer.h (Diff revision 1)
     
     
    Show all issues

    s/an/a

  4. libpurple/purplefiletransfer.h (Diff revision 1)
     
     
    Show all issues

    The enum is PURPLE_FILE_TRANSFER_STATE_FAILED without CANCELLED.

  5. libpurple/purplefiletransfer.h (Diff revision 1)
     
     
    Show all issues

    s/receieve/receive

  6. libpurple/purplefiletransfer.h (Diff revision 1)
     
     
    Show all issues

    Should the 2nd transfer be prefixed with an @?

  7. libpurple/purplefiletransfer.h (Diff revision 1)
     
     
    Show all issues

    missing a or the before protocol plugin?

  8. libpurple/purplefiletransfer.c (Diff revision 1)
     
     
    Show all issues

    Having both of the transfer and for this transfer seems superfluous.

  9. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed