Summary

Implement PurpleFileTransfer

Review Request #2625 — Created Sept. 25, 2023 and submitted Oct. 3, 2023, 4:59 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17830

Depends On

Reviewers

Groups

pidgin

People

Description

This initial implementation only implements the properties and defines the
basic flow. This does not actually implement any of the actual behavior as
that'll be done later when we can implement the whole thing.

Testing Done

Ran the unittests under valgrind.

Commits

Summary	ID
Implement PurpleFileTransfer This initial implementation only implements the properties and defines the basic flow. This does not actually implement any of the actual behavior as that'll be done later when we can implement the whole thing.	691d77a345e11d72c1971cd83b12a5eec3761ae9

Issues

Description	From	Last Updated
s/whose/who's	ivanhoe	Sept. 30, 2023, 6:47 a.m.
s/an/a	ivanhoe	Sept. 30, 2023, 6:47 a.m.
The enum is PURPLE_FILE_TRANSFER_STATE_FAILED without CANCELLED.	ivanhoe	Sept. 30, 2023, 6:49 a.m.
s/receieve/receive	ivanhoe	Sept. 30, 2023, 6:50 a.m.
Should the 2nd transfer be prefixed with an @?	ivanhoe	Sept. 30, 2023, 6:50 a.m.
missing a or the before protocol plugin?	ivanhoe	Sept. 30, 2023, 6:50 a.m.
Having both of the transfer and for this transfer seems superfluous.	ivanhoe	Sept. 30, 2023, 6:50 a.m.

libpurple/purplefiletransfer.h (Diff revision 1)
Show all issues
```
s/whose/who's
```
libpurple/purplefiletransfer.h (Diff revision 1)
Show all issues
```
s/an/a
```

libpurple/purplefiletransfer.h (Diff revision 1)

Show all issues

The enum is PURPLE_FILE_TRANSFER_STATE_FAILED without CANCELLED.

libpurple/purplefiletransfer.h (Diff revision 1)
Show all issues
```
s/receieve/receive
```
libpurple/purplefiletransfer.h (Diff revision 1)
Show all issues
```
Should the 2nd transfer be prefixed with an @?
```
libpurple/purplefiletransfer.h (Diff revision 1)
Show all issues
```
missing a or the before protocol plugin?
```

libpurple/purplefiletransfer.c (Diff revision 1)

Show all issues

Having both of the transfer and for this transfer seems superfluous.

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Implement PurpleFileTransfer This initial implementation only implements the properties and defines the basic flow. This does not actually implement any of the actual behavior as that'll be done later when we can implement the whole thing.	10bf263e813873a2302655f2eb975f7a51658132
	Implement PurpleFileTransfer This initial implementation only implements the properties and defines the basic flow. This does not actually implement any of the actual behavior as that'll be done later when we can implement the whole thing.	691d77a345e11d72c1971cd83b12a5eec3761ae9

Diff:

Revision 2 (+2376)

Show changes

	libpurple/meson.build
	libpurple/purplefiletransfer.h
	libpurple/purplefiletransfer.c
	libpurple/tests/meson.build
	libpurple/tests/test_file_transfer.c

Ship it!

```
Ship It!
```

Review Board 6.0.1