Clean up a bunch of stuff in accounts

Review Request #2623 — Created Sept. 20, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This is pretty much just removing alignments and updating stuff to our current
coding standards.

Ran the unit tests.

Summary ID
Clean up a bunch of stuff in accounts
This is pretty much just removing alignments and updating stuff to our current coding standards.
d3d4b802ac7cd9c8d28472deaab18c2ee7f47479
Description From Last Updated

Is this TODO no longer needed?

QuLogicQuLogic

This can use purple_strempty.

QuLogicQuLogic

Weird alignment.

QuLogicQuLogic

Can remove the extra parentheses here.

QuLogicQuLogic

Should you add a PURPLE_IS_ACCOUNT check on these three?

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/account.c (Diff revision 2)
     
     
    Show all issues

    Is this TODO no longer needed?

    1. It was written by someone else, but regardless we still need the field for serialization at the moment as well as error reporting or something when if the protocol is missing. We could clean it up in another review request though or just delete the comment I suppose.

    2. I'm asking because you deleted the comment.

    3. derp sorry was really tired when I made the change and my response.

      At any rate, we still need protocol_id for now for the reasons I mentioned in my previous comment which conflict with the idea that a protocol instance could solve the issue.

  3. libpurple/account.c (Diff revision 2)
     
     
    Show all issues

    This can use purple_strempty.

  4. libpurple/account.c (Diff revision 2)
     
     
    Show all issues

    Weird alignment.

  5. libpurple/account.c (Diff revision 2)
     
     
    Show all issues

    Can remove the extra parentheses here.

  6. libpurple/account.c (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Should you add a PURPLE_IS_ACCOUNT check on these three?

  7. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed