Summary

Clean up a bunch of stuff in accounts

Review Request #2623 — Created Sept. 20, 2023 and submitted Oct. 6, 2023, 4:51 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is pretty much just removing alignments and updating stuff to our current
coding standards.

Testing Done

Ran the unit tests.

Commits

Summary	ID
Clean up a bunch of stuff in accounts This is pretty much just removing alignments and updating stuff to our current coding standards.	d3d4b802ac7cd9c8d28472deaab18c2ee7f47479

Issues

Description	From	Last Updated
Is this TODO no longer needed?	QuLogic	Oct. 6, 2023, 3:33 a.m.
This can use purple_strempty.	QuLogic	Oct. 6, 2023, 3:33 a.m.
Weird alignment.	QuLogic	Oct. 6, 2023, 3:33 a.m.
Can remove the extra parentheses here.	QuLogic	Oct. 6, 2023, 3:33 a.m.
Should you add a PURPLE_IS_ACCOUNT check on these three?	QuLogic	Oct. 6, 2023, 3:33 a.m.

Change Summary:

fix the license header in account.h

Commits:

	Summary	ID
	Clean up a bunch of stuff in accounts This is pretty much just removing alignments and updating stuff to our current coding standards.	f844307b32dfcb3a528863c521a2f1d4469c3f98
	Clean up a bunch of stuff in accounts This is pretty much just removing alignments and updating stuff to our current coding standards.	1ad6de4a99c54296ddf6418830522e1d4a92d252

Diff:

Revision 2 (+592 -686)

Show changes

	ChangeLog.API
	libpurple/account.h
	libpurple/account.c

libpurple/account.c (Diff revision 2)

The issue has been dropped. Show all issues

Is this TODO no longer needed?

grim Sept. 22, 2023, 7:05 a.m.

It was written by someone else, but regardless we still need the field for serialization at the moment as well as error reporting or something when if the protocol is missing. We could clean it up in another review request though or just delete the comment I suppose.

QuLogic Sept. 22, 2023, 7:13 a.m.

I'm asking because you deleted the comment.

grim Sept. 23, 2023, 5:14 a.m.

derp sorry was really tired when I made the change and my response.

At any rate, we still need protocol_id for now for the reasons I mentioned in my previous comment which conflict with the idea that a protocol instance could solve the issue.

libpurple/account.c (Diff revision 2)
The issue has been resolved. Show all issues
```
This can use purple_strempty.
```
libpurple/account.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Weird alignment.
```
libpurple/account.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Can remove the extra parentheses here.
```

libpurple/account.c (Diff revision 2)

The issue has been resolved. Show all issues

Should you add a PURPLE_IS_ACCOUNT check on these three?

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Clean up a bunch of stuff in accounts This is pretty much just removing alignments and updating stuff to our current coding standards.	1ad6de4a99c54296ddf6418830522e1d4a92d252
	Clean up a bunch of stuff in accounts This is pretty much just removing alignments and updating stuff to our current coding standards.	d3d4b802ac7cd9c8d28472deaab18c2ee7f47479

Diff:

Revision 3 (+604 -686)

Show changes

	ChangeLog.API
	libpurple/account.h
	libpurple/account.c

Ship it!

```
Ship It!
```

Status:: Completed