Summary

Add PurpleProtocolConversation->set_topic_async and _finish

Review Request #2613 — Created Sept. 12, 2023 and submitted Sept. 19, 2023, 6:38 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2611~~

Groups

People

Description

This will allow protocols to tell us whether or not setting a topic was
successful.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add PurpleProtocolConversation->set_topic_async and _finish This will allow protocols to tell us whether or not setting a topic was successful.	1dbf44c7c54b55c75d2c7b4d3d71a4457250868a

Issues

Description	From	Last Updated
Alignment is a bit off.	QuLogic	Sept. 19, 2023, 6:34 a.m.

libpurple/purpleprotocolconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Alignment is a bit off.
```

libpurple/tests/test_protocol_conversation.c (Diff revision 1)

Note, all fields are nulled out, so this is technically not needed.

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Add PurpleProtocolConversation->set_topic_async and _finish This will allow protocols to tell us whether or not setting a topic was successful.	27bed3844d5c9c3a6668329a291cba3956eb5c52
	Add PurpleProtocolConversation->set_topic_async and _finish This will allow protocols to tell us whether or not setting a topic was successful.	1dbf44c7c54b55c75d2c7b4d3d71a4457250868a

Diff:

	libpurple/purpleprotocolconversation.h
	libpurple/purpleprotocolconversation.c
	libpurple/tests/test_protocol_conversation.c

Ship it!