Summary

Add color and color-for-display properties to PurplePerson

Review Request #2602 — Created Sept. 2, 2023 and submitted Sept. 5, 2023, 4:44 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17817

Depends On

Reviewers

Groups

pidgin

People

Description

The color property allows setting a custom color for PurplePerson that should
be used whenever displaying the person or a contact from that person.

To make this easier the color-for-display property should be used as it will
fallback to the priority contact if the person does not have a color set.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add color and color-for-display properties to PurplePerson The color property allows setting a custom color for PurplePerson that should be used whenever displaying the person or a contact from that person. To make this easier the color-for-display property should be used as it will fallback to the priority contact if the person does not have a color set.	e1a8a0327148f6accc99bceee1f64996312e4f83

Issues

Description	From	Last Updated
Now that we're at 3 connections, I think maybe you can connect to plain notify? But I don't know if …	QuLogic	Sept. 5, 2023, 4:36 a.m.
Was this debug?	QuLogic	Sept. 5, 2023, 4:37 a.m.
s/to display //	QuLogic	Sept. 5, 2023, 4:37 a.m.
s/well/will/	QuLogic	Sept. 5, 2023, 4:37 a.m.
Should be avatar1 == avatar_for_display, I think?	QuLogic	Sept. 5, 2023, 4:37 a.m.
s/an verify that we not/and verify that we are /	QuLogic	Sept. 5, 2023, 4:37 a.m.

libpurple/purpleperson.c (Diff revision 1)

Show all issues

Now that we're at 3 connections, I think maybe you can connect to plain notify? But I don't know if handling all details is better than having 3 connections.

libpurple/purpleperson.c (Diff revision 1)
Show all issues
```
Was this debug?
```
libpurple/purpleperson.c (Diff revision 1)
Show all issues
```
s/to display //
```
libpurple/purpleperson.c (Diff revision 1)
Show all issues
```
s/well/will/
```
libpurple/tests/test_person.c (Diff revision 1)
Show all issues
```
Should be avatar1 == avatar_for_display, I think?
```
libpurple/tests/test_person.c (Diff revision 1)
Show all issues
```
s/an verify that we not/and verify that we are /
```

Change Summary:

rebased and addresses issues

Commits:

	Summary	ID
	Add color and color-for-display properties to PurplePerson The color property allows setting a custom color for PurplePerson that should be used whenever displaying the person or a contact from that person. To make this easier the color-for-display property should be used as it will fallback to the priority contact if the person does not have a color set.	59f7e2d57b9040b7a14baeaea5a8e9bd0fff0fb7
	Add color and color-for-display properties to PurplePerson The color property allows setting a custom color for PurplePerson that should be used whenever displaying the person or a contact from that person. To make this easier the color-for-display property should be used as it will fallback to the priority contact if the person does not have a color set.	e1a8a0327148f6accc99bceee1f64996312e4f83

Diff:

Revision 2 (+538 -52)

Show changes

	libpurple/purpleperson.h
	libpurple/purpleperson.c
	libpurple/tests/test_person.c

Ship it!

```
Ship It!
```

Review Board 6.0.2