Add color and color-for-display properties to PurplePerson

Review Request #2602 — Created Sept. 2, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

The color property allows setting a custom color for PurplePerson that should
be used whenever displaying the person or a contact from that person.

To make this easier the color-for-display property should be used as it will
fallback to the priority contact if the person does not have a color set.

Ran the unit tests under valgrind.

Summary ID
Add color and color-for-display properties to PurplePerson
The color property allows setting a custom color for PurplePerson that should be used whenever displaying the person or a contact from that person. To make this easier the color-for-display property should be used as it will fallback to the priority contact if the person does not have a color set.
e1a8a0327148f6accc99bceee1f64996312e4f83
Description From Last Updated

Now that we're at 3 connections, I think maybe you can connect to plain notify? But I don't know if …

QuLogicQuLogic

Was this debug?

QuLogicQuLogic

s/to display //

QuLogicQuLogic

s/well/will/

QuLogicQuLogic

Should be avatar1 == avatar_for_display, I think?

QuLogicQuLogic

s/an verify that we not/and verify that we are /

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/purpleperson.c (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Now that we're at 3 connections, I think maybe you can connect to plain notify? But I don't know if handling all details is better than having 3 connections.

  3. libpurple/purpleperson.c (Diff revision 1)
     
     
    Show all issues

    Was this debug?

  4. libpurple/purpleperson.c (Diff revision 1)
     
     
    Show all issues

    s/to display //

  5. libpurple/purpleperson.c (Diff revision 1)
     
     
    Show all issues

    s/well/will/

  6. libpurple/tests/test_person.c (Diff revision 1)
     
     
    Show all issues

    Should be avatar1 == avatar_for_display, I think?

  7. libpurple/tests/test_person.c (Diff revision 1)
     
     
    Show all issues

    s/an verify that we not/and verify that we are /

  8. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed