-
-
libpurple/purpleperson.c (Diff revision 1) Now that we're at 3 connections, I think maybe you can connect to plain
notify? But I don't know if handling all details is better than having 3 connections. -
-
-
-
-
Add color and color-for-display properties to PurplePerson
Review Request #2602 — Created Sept. 2, 2023 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| PIDGIN-17817 | |
| Reviewers | |
| pidgin | |
The color property allows setting a custom color for PurplePerson that should be used whenever displaying the person or a contact from that person. To make this easier the color-for-display property should be used as it will fallback to the priority contact if the person does not have a color set.
Ran the unit tests under valgrind.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Now that we're at 3 connections, I think maybe you can connect to plain notify? But I don't know if … |
 QuLogic
|
|
|
Was this debug? |
QuLogic
|
|
|
s/to display // |
QuLogic
|
|
|
s/well/will/ |
QuLogic
|
|
|
Should be avatar1 == avatar_for_display, I think? |
QuLogic
|
|
|
s/an verify that we not/and verify that we are / |
QuLogic
|
Change Summary:
rebased and addresses issues
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+538 -52) |
|||||||||