Add delivered and delivered-at properties to PurpleMessage

Review Request #2600 — Created Sept. 1, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

These properties are co-dependent and will set the other when they are set.

Ran the unit tests under valgrind.

Summary ID
Add delivered and delivered-at properties to PurpleMessage
These properties are co-dependent and will set the other when they are set.
e79fcbce8efafa0ab114939dee0597631cff6649
Description From Last Updated

s/receipts/receipts,/

QuLogicQuLogic

Based on the setters, it appears that these are always in sync with delivered == (delivered_at != NULL). I'm not …

QuLogicQuLogic

s/delivered at/delivered-at/

QuLogicQuLogic

s/use.+/us, making an infinite loop./

QuLogicQuLogic

I guess we can just do if(delivered) {

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/purplemessage.h (Diff revision 1)
     
     
    Show all issues

    s/receipts/receipts,/

  3. libpurple/purplemessage.c (Diff revision 1)
     
     
     
    Show all issues

    Based on the setters, it appears that these are always in sync with delivered == (delivered_at != NULL). I'm not sure if we can drop saving the boolean?

    1. QuLogic from Twitch: "I only mean in the struct"

      Yeah that would probably be easier.

  4. libpurple/purplemessage.c (Diff revision 1)
     
     
    Show all issues

    s/delivered at/delivered-at/

  5. libpurple/purplemessage.c (Diff revision 1)
     
     
    Show all issues

    s/use.+/us, making an infinite loop./

  6. 
      
grim
QuLogic
  1. 
      
  2. libpurple/purplemessage.c (Diff revisions 1 - 2)
     
     
     
     
     
     
     
     
    Show all issues

    I guess we can just do if(delivered) {

  3. 
      
grim
grim
Review request changed
Status:
Completed