Summary

Add delivered and delivered-at properties to PurpleMessage

Review Request #2600 — Created Sept. 1, 2023 and submitted Sept. 5, 2023, 4:40 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

These properties are co-dependent and will set the other when they are set.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add delivered and delivered-at properties to PurpleMessage These properties are co-dependent and will set the other when they are set.	e79fcbce8efafa0ab114939dee0597631cff6649

Issues

Description	From	Last Updated
s/receipts/receipts,/	QuLogic	Sept. 5, 2023, 4:27 a.m.
Based on the setters, it appears that these are always in sync with delivered == (delivered_at != NULL). I'm not …	QuLogic	Sept. 5, 2023, 4:33 a.m.
s/delivered at/delivered-at/	QuLogic	Sept. 5, 2023, 4:27 a.m.
s/use.+/us, making an infinite loop./	QuLogic	Sept. 5, 2023, 4:27 a.m.
I guess we can just do if(delivered) {	QuLogic	Sept. 5, 2023, 4:39 a.m.

libpurple/purplemessage.h (Diff revision 1)
Show all issues
```
s/receipts/receipts,/
```

libpurple/purplemessage.c (Diff revision 1)

Show all issues

Based on the setters, it appears that these are always in sync with delivered == (delivered_at != NULL). I'm not sure if we can drop saving the boolean?

grim Sept. 5, 2023, 4:18 a.m.

QuLogic from Twitch: "I only mean in the struct"

Yeah that would probably be easier.

libpurple/purplemessage.c (Diff revision 1)
Show all issues
```
s/delivered at/delivered-at/
```
libpurple/purplemessage.c (Diff revision 1)
Show all issues
```
s/use.+/us, making an infinite loop./
```

Change Summary:

rebase, address issues, and ditch the boolean delivered struct member.

Commits:

	Summary	ID
	Add delivered and delivered-at properties to PurpleMessage These properties are co-dependent and will set the other when they are set.	84696a1adeb7364c17ad6b770076ed3b808c1a57
	Add delivered and delivered-at properties to PurpleMessage These properties are co-dependent and will set the other when they are set.	ebee6e64b6825cddb942f317a98bae556e8c279d

Diff:

Revision 2 (+568 -2)

Show changes

	libpurple/purplemessage.h
	libpurple/purplemessage.c
	libpurple/tests/test_message.c

Ship it!

libpurple/purplemessage.c (Diff revisions 1 - 2)

Show all issues

I guess we can just do if(delivered) {

Change Summary:

removed unnecessary == TRUE

Commits:

	Summary	ID
	Add delivered and delivered-at properties to PurpleMessage These properties are co-dependent and will set the other when they are set.	ebee6e64b6825cddb942f317a98bae556e8c279d
	Add delivered and delivered-at properties to PurpleMessage These properties are co-dependent and will set the other when they are set.	e79fcbce8efafa0ab114939dee0597631cff6649

Diff:

Revision 3 (+568 -2)

Show changes

	libpurple/purplemessage.h
	libpurple/purplemessage.c
	libpurple/tests/test_message.c

Review Board 6.0.2

Add delivered and delivered-at properties to PurpleMessage

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)