-
-
-
libpurple/purplemessage.c (Diff revision 1) Based on the setters, it appears that these are always in sync with
delivered == (delivered_at != NULL). I'm not sure if we can drop saving the boolean? -
-
Add delivered and delivered-at properties to PurpleMessage
Review Request #2600 — Created Sept. 1, 2023 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| Reviewers | |
| pidgin | |
These properties are co-dependent and will set the other when they are set.
Ran the unit tests under valgrind.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
s/receipts/receipts,/ |
 QuLogic
|
|
|
Based on the setters, it appears that these are always in sync with delivered == (delivered_at != NULL). I'm not … |
QuLogic
|
|
|
s/delivered at/delivered-at/ |
QuLogic
|
|
|
s/use.+/us, making an infinite loop./ |
QuLogic
|
|
|
I guess we can just do if(delivered) { |
QuLogic
|
Change Summary:
rebase, address issues, and ditch the boolean delivered struct member.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+568 -2) |
|||||||||
Change Summary:
removed unnecessary
== TRUE
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+568 -2) |
|||||||||