Summary

Add PurpleConversationType

Review Request #2599 — Created Sept. 1, 2023 and submitted Sept. 5, 2023, 5:44 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is mostly meant to be used by the protocols and maybe the user interfaces
to do things they might need to do. Internally to libpurple this is basically
ignored.

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add PurpleConversationType This is mostly meant to be used by the protocols and maybe the user interfaces to do things they might need to do. Internally to libpurple this is basically ignored.	67a0989a811259a327f99c9d952ecbb16dd6afbf

Issues

Description	From	Last Updated
s/determine/specify/ I think	QuLogic	Sept. 5, 2023, 5:42 a.m.
subset of messages	QuLogic	Sept. 5, 2023, 5:42 a.m.
ignored	QuLogic	Sept. 5, 2023, 5:42 a.m.
in the future	QuLogic	Sept. 5, 2023, 5:42 a.m.
Was re-ordering needed? It doesn't match the PROP_* constants or property getter/setter code now.	QuLogic	Sept. 5, 2023, 5:42 a.m.

libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
s/determine/specify/ I think
```
libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
subset of messages
```
libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
ignored
```
libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
in the future
```

libpurple/purpleconversation.c (Diff revision 1)

Show all issues

Was re-ordering needed? It doesn't match the PROP_* constants or property getter/setter code now.

Change Summary:

rebased, addressed issues, found some more issues and fixed them too!

Commits:

	Summary	ID
	Add PurpleConversationType This is mostly meant to be used by the protocols and maybe the user interfaces to do things they might need to do. Internally to libpurple this is basically ignored.	6948be10019442111c80326a2faef104626b9d56
	Add PurpleConversationType This is mostly meant to be used by the protocols and maybe the user interfaces to do things they might need to do. Internally to libpurple this is basically ignored.	67a0989a811259a327f99c9d952ecbb16dd6afbf

Diff:

Revision 2 (+226 -2)

Show changes

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c

Ship it!

```
Ship It!
```

Review Board 6.0.2