Summary

Add purple_conversation_set_topic_full

Review Request #2598 — Created Sept. 1, 2023 and submitted Sept. 5, 2023, 3:45 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This allows a protocol to make a single call rather than three to update the
topic.

Testing Done

Ran the unit tests

Commits

Summary	ID
Add purple_conversation_set_topic_full This allows a protocol to make a single call rather than three to update the topic.	22bb4274b25df38b9dcec8ccdfce240981250da6

Issues

Description	From	Last Updated
s/the everything/everything/ And the second sentence kind of repeats the first one a bit?	QuLogic	Sept. 5, 2023, 3:41 a.m.
Was the French intentional?	QuLogic	Sept. 5, 2023, 3:41 a.m.

libpurple/purpleconversation.h (Diff revision 1)

Show all issues

s/the everything/everything/

And the second sentence kind of repeats the first one a bit?

libpurple/tests/test_conversation.c (Diff revision 1)

Show all issues

Was the French intentional?

grim Sept. 5, 2023, 3:22 a.m.

It was a reference to https://en.wikipedia.org/wiki/The_Day_the_Earth_Stood_Stupid but I spelled it wrong, so I'm just going to remove it.

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Add purple_conversation_set_topic_full This allows a protocol to make a single call rather than three to update the topic.	a0e928ad6fa264cf0abd35b6a29fc03769c898cc
	Add purple_conversation_set_topic_full This allows a protocol to make a single call rather than three to update the topic.	22bb4274b25df38b9dcec8ccdfce240981250da6

Diff:

Revision 2 (+154)

Show changes

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c

Ship it!

```
Ship It!
```

Review Board 6.0.2