Summary

Add the conversation as a parameter to PurpleProtocolChat->send

Review Request #2596 — Created Sept. 1, 2023 and submitted Sept. 5, 2023, 4:11 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17826

Depends On

Reviewers

Groups

pidgin

People

Description

This is an incremental update so that all of the implemenations can start
moving in this direction. Eventually this be something like
PurpleProtocol->send_message or something which will be used for both ims and
chats.

Testing Done

Joined an XMPP muc and sent some messages.

Commits

Summary	ID
Add the conversation as a parameter to PurpleProtocolChat->send This is an incremental update so that all of the implemenations can start moving in this direction. Eventually this be something like PurpleProtocol->send_message or something which will be used for both ims and chats.	1f161cd8a8a06473a31e77bd7868128727b49d5d

Bugs:

+	PIDGIN-17826

Ship it!

```
Ship It!
```

Change Summary:

rebased

Commits:

	Summary	ID
	Add the conversation as a parameter to PurpleProtocolChat->send This is an incremental update so that all of the implemenations can start moving in this direction. Eventually this be something like PurpleProtocol->send_message or something which will be used for both ims and chats.	70f971c80561e3cdfdee7acf4a9d9604bc7cfd7f
	Add the conversation as a parameter to PurpleProtocolChat->send This is an incremental update so that all of the implemenations can start moving in this direction. Eventually this be something like PurpleProtocol->send_message or something which will be used for both ims and chats.	1f161cd8a8a06473a31e77bd7868128727b49d5d

Diff:

Revision 2 (+56 -26)

Show changes

	libpurple/purpleprotocolchat.h
	libpurple/purpleprotocolchat.c
	libpurple/server.c
	libpurple/protocols/gg/chat.h
	libpurple/protocols/gg/chat.c
	libpurple/protocols/jabber/message.h
	libpurple/protocols/jabber/message.c

Review Board 6.0.2