Summary

Make PurpleMessage::id writeable

Review Request #2593 — Created Aug. 29, 2023 and submitted Sept. 5, 2023, 4:52 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Most protocols will accept a new message with a provisional ID and then send
the message back with the final id among other things. To make this work, the
id property needs to be writeable.

Testing Done

Ran the unit tests

Commits

Summary	ID
Make PurpleMessage::id writeable Most protocols will accept a new message with a provisional ID and then send the message back with the final id among other things. To make this work, the id property needs to be writeable.	574c574947465c1f276189405e2c85f9469de1d1

Issues

Description	From	Last Updated
Hyphenate: protocol-specific	QuLogic	Sept. 5, 2023, 4:50 a.m.

Ship it!

```
Ship It!
```
libpurple/purplemessage.c (Diff revision 1)
Show all issues
```
Hyphenate: protocol-specific
```

Change Summary:

rebase and fix comment.

Commits:

	Summary	ID
	Make PurpleMessage::id writeable Most protocols will accept a new message with a provisional ID and then send the message back with the final id among other things. To make this work, the id property needs to be writeable.	f20bbdcb8c30ba11b623cc77e446cfdb0c20c78a
	Make PurpleMessage::id writeable Most protocols will accept a new message with a provisional ID and then send the message back with the final id among other things. To make this work, the id property needs to be writeable.	574c574947465c1f276189405e2c85f9469de1d1

Diff:

Revision 2 (+54 -22)

Show changes

	libpurple/purplemessage.h
	libpurple/purplemessage.c

Review Board 6.0.2