A basic context menu for PurpleContactInfo

Review Request #2592 — Created Aug. 29, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This is currently only displayed via the contact list and it takes a shortcut
to just show the menu for the priority contact.

The view profile option currently just logs the profile as we need to determine
how we want the user interface to look/work for this yet.

Verified that view profile was disabled for an xmpp account.
Verified that view profile worked for a demo contact with a profile and one without.

Summary ID
A basic context menu for PurpleContactInfo
This is currently only displayed via the contact list and it takes a shortcut to just show the menu for the priority contact. The view profile option currently just logs the profile as we need to determine how we want the user interface to look/work for this yet.
d6e07acb35848d039a3b4905ad2bbf04b9d1af31
Description From Last Updated

s/and display //

QuLogicQuLogic

Leaks account_id and contact_id.

QuLogicQuLogic

Leaks account_id and contact_id.

QuLogicQuLogic

It does now?

QuLogicQuLogic

contact is leaked?

QuLogicQuLogic

Ditto.

QuLogicQuLogic

Registration takes a ref, I think, so this new conversation leaks.

QuLogicQuLogic

section is leaked here, since g_menu_append_section is transfer none.

QuLogicQuLogic

We can leave out swapped, I think?

QuLogicQuLogic

account is leaked at the end here, and contact is leaked if the if conditions are not fulfilled.

QuLogicQuLogic

account is leaked at the end.

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/pidgincontactinfomenu.h (Diff revision 1)
     
     
    Show all issues

    s/and display //

  3. pidgin/pidgincontactinfomenu.c (Diff revision 1)
     
     
    Show all issues

    Leaks account_id and contact_id.

  4. pidgin/pidgincontactinfomenu.c (Diff revision 1)
     
     
    Show all issues

    Leaks account_id and contact_id.

  5. pidgin/pidgincontactinfomenu.c (Diff revision 1)
     
     
     
     
    Show all issues

    It does now?

  6. pidgin/pidgincontactinfomenu.c (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Show all issues

    contact is leaked?

  7. pidgin/pidgincontactinfomenu.c (Diff revision 1)
     
     
     
     
    Show all issues

    Ditto.

  8. pidgin/pidgincontactinfomenu.c (Diff revision 1)
     
     
     
    Show all issues

    Registration takes a ref, I think, so this new conversation leaks.

  9. pidgin/pidgincontactinfomenu.c (Diff revision 1)
     
     
     
    Show all issues

    section is leaked here, since g_menu_append_section is transfer none.

  10. pidgin/resources/ContactList/widget.ui (Diff revision 1)
     
     
    Show all issues

    We can leave out swapped, I think?

    1. I think it's something about the nested template but we don't get the right types without it.

  11. 
      
grim
QuLogic
  1. 
      
  2. pidgin/pidgincontactinfomenu.c (Diff revision 2)
     
     
    Show all issues

    account is leaked at the end here, and contact is leaked if the if conditions are not fulfilled.

  3. pidgin/pidgincontactinfomenu.c (Diff revision 2)
     
     
     
    Show all issues

    account is leaked at the end.

  4. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed