Summary

A basic context menu for PurpleContactInfo

Review Request #2592 — Created Aug. 29, 2023 and submitted Sept. 5, 2023, 3:58 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17682

Depends On

Reviewers

Groups

pidgin

People

Description

This is currently only displayed via the contact list and it takes a shortcut
to just show the menu for the priority contact.

The view profile option currently just logs the profile as we need to determine
how we want the user interface to look/work for this yet.

Testing Done

Verified that view profile was disabled for an xmpp account.
Verified that view profile worked for a demo contact with a profile and one without.

Commits

Summary	ID
A basic context menu for PurpleContactInfo This is currently only displayed via the contact list and it takes a shortcut to just show the menu for the priority contact. The view profile option currently just logs the profile as we need to determine how we want the user interface to look/work for this yet.	d6e07acb35848d039a3b4905ad2bbf04b9d1af31

Issues

Description	From	Last Updated
s/and display //	QuLogic	Sept. 5, 2023, 3:42 a.m.
Leaks account_id and contact_id.	QuLogic	Sept. 5, 2023, 3:42 a.m.
Leaks account_id and contact_id.	QuLogic	Sept. 5, 2023, 3:42 a.m.
It does now?	QuLogic	Sept. 5, 2023, 3:42 a.m.
contact is leaked?	QuLogic	Sept. 5, 2023, 3:45 a.m.
Ditto.	QuLogic	Sept. 5, 2023, 3:43 a.m.
Registration takes a ref, I think, so this new conversation leaks.	QuLogic	Sept. 5, 2023, 3:43 a.m.
section is leaked here, since g_menu_append_section is transfer none.	QuLogic	Sept. 5, 2023, 3:43 a.m.
We can leave out swapped, I think?	QuLogic	Sept. 5, 2023, 3:43 a.m.
account is leaked at the end here, and contact is leaked if the if conditions are not fulfilled.	QuLogic	Sept. 5, 2023, 3:53 a.m.
account is leaked at the end.	QuLogic	Sept. 5, 2023, 3:53 a.m.

pidgin/pidgincontactinfomenu.h (Diff revision 1)
Show all issues
```
s/and display //
```
pidgin/pidgincontactinfomenu.c (Diff revision 1)
Show all issues
```
Leaks account_id and contact_id.
```
pidgin/pidgincontactinfomenu.c (Diff revision 1)
Show all issues
```
Leaks account_id and contact_id.
```
pidgin/pidgincontactinfomenu.c (Diff revision 1)
Show all issues
```
It does now?
```

pidgin/pidgincontactinfomenu.c (Diff revision 1)

Show all issues

contact is leaked?

pidgin/pidgincontactinfomenu.c (Diff revision 1)
Show all issues
```
Ditto.
```

pidgin/pidgincontactinfomenu.c (Diff revision 1)

Show all issues

Registration takes a ref, I think, so this new conversation leaks.

pidgin/pidgincontactinfomenu.c (Diff revision 1)

Show all issues

section is leaked here, since g_menu_append_section is transfer none.

pidgin/resources/ContactList/widget.ui (Diff revision 1)

Show all issues

We can leave out swapped, I think?

grim Sept. 5, 2023, 3:41 a.m.

I think it's something about the nested template but we don't get the right types without it.

Change Summary:

rebase and address issues.

Commits:

	Summary	ID
	A basic context menu for PurpleContactInfo This is currently only displayed via the contact list and it takes a shortcut to just show the menu for the priority contact. The view profile option currently just logs the profile as we need to determine how we want the user interface to look/work for this yet.	79abea5e4b646b8ef5c1806294f7fca2b7d38f25
	A basic context menu for PurpleContactInfo This is currently only displayed via the contact list and it takes a shortcut to just show the menu for the priority contact. The view profile option currently just logs the profile as we need to determine how we want the user interface to look/work for this yet.	239b732c174c1f38d59fdfb71b3c2180a518477c

Diff:

Revision 2 (+988 -4)

Show changes

	libpurple/protocols/demo/meson.build
	libpurple/protocols/demo/purpledemocontacts.c
	libpurple/protocols/demo/purpledemoprotocol.c
	libpurple/protocols/demo/purpledemoprotocolcontacts.h
	libpurple/protocols/demo/purpledemoprotocolcontacts.c
	libpurple/protocols/demo/resources/contacts.json
	pidgin/meson.build
	pidgin/pidgincontactinfomenu.h
	4 more

pidgin/pidgincontactinfomenu.c (Diff revision 2)

Show all issues

account is leaked at the end here, and contact is leaked if the if conditions are not fulfilled.

pidgin/pidgincontactinfomenu.c (Diff revision 2)
Show all issues
```
account is leaked at the end.
```

Change Summary:

rebased and addressed the additional issues.

Commits:

	Summary	ID
	A basic context menu for PurpleContactInfo This is currently only displayed via the contact list and it takes a shortcut to just show the menu for the priority contact. The view profile option currently just logs the profile as we need to determine how we want the user interface to look/work for this yet.	239b732c174c1f38d59fdfb71b3c2180a518477c
	A basic context menu for PurpleContactInfo This is currently only displayed via the contact list and it takes a shortcut to just show the menu for the priority contact. The view profile option currently just logs the profile as we need to determine how we want the user interface to look/work for this yet.	d6e07acb35848d039a3b4905ad2bbf04b9d1af31

Diff:

Revision 3 (+996 -4)

Show changes

	libpurple/protocols/demo/meson.build
	libpurple/protocols/demo/purpledemocontacts.c
	libpurple/protocols/demo/purpledemoprotocol.c
	libpurple/protocols/demo/purpledemoprotocolcontacts.h
	libpurple/protocols/demo/purpledemoprotocolcontacts.c
	libpurple/protocols/demo/resources/contacts.json
	pidgin/meson.build
	pidgin/pidgincontactinfomenu.h
	4 more

Bugs:

+	PIDGIN-17682

Ship it!

```
Ship It!
```

Review Board 6.0.2

A basic context menu for PurpleContactInfo

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Bugs:

Status: Closed (submitted)