-
-
-
-
-
-
-
-
pidgin/pidgincontactinfomenu.c (Diff revision 1) Registration takes a ref, I think, so this new
conversationleaks. -
pidgin/pidgincontactinfomenu.c (Diff revision 1) sectionis leaked here, sinceg_menu_append_sectionis transfer none. -
A basic context menu for PurpleContactInfo
Review Request #2592 — Created Aug. 29, 2023 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| PIDGIN-17682 | |
| Reviewers | |
| pidgin | |
This is currently only displayed via the contact list and it takes a shortcut to just show the menu for the priority contact. The view profile option currently just logs the profile as we need to determine how we want the user interface to look/work for this yet.
Verified that
view profilewas disabled for an xmpp account.
Verified thatview profileworked for a demo contact with a profile and one without.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
s/and display // |
 QuLogic
|
|
|
Leaks account_id and contact_id. |
QuLogic
|
|
|
Leaks account_id and contact_id. |
QuLogic
|
|
|
It does now? |
QuLogic
|
|
|
contact is leaked? |
QuLogic
|
|
|
Ditto. |
QuLogic
|
|
|
Registration takes a ref, I think, so this new conversation leaks. |
QuLogic
|
|
|
section is leaked here, since g_menu_append_section is transfer none. |
QuLogic
|
|
|
We can leave out swapped, I think? |
QuLogic
|
|
|
account is leaked at the end here, and contact is leaked if the if conditions are not fulfilled. |
QuLogic
|
|
|
account is leaked at the end. |
QuLogic
|
Change Summary:
rebase and address issues.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+988 -4) |
|||||||||
-
-
pidgin/pidgincontactinfomenu.c (Diff revision 2) accountis leaked at the end here, andcontactis leaked if theifconditions are not fulfilled. -
Change Summary:
rebased and addressed the additional issues.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+996 -4) |
|||||||||