Summary

The start of the new conversation window

Review Request #2589 — Created Aug. 29, 2023 and submitted Sept. 5, 2023, 3:17 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The start of the new conversation window

Testing Done

Sent some messages on XMPP and IRCv3.

Commits

Summary	ID
The start of the new conversation window	d6a7e08315ff9f2e42303d8be92dbd38c5869fde

Files

Issues

Description	From	Last Updated
s/display/displaying	QuLogic	Sept. 5, 2023, 2:47 a.m.
s/only for display if/is only for display; if/	QuLogic	Sept. 5, 2023, 2:47 a.m.
Do we need to clear this somewhere? Since the conversation property is construct-only, maybe only in dispose?	QuLogic	Sept. 5, 2023, 2:49 a.m.
self is a bit of a confusing variable name for me, since that's not the class defined in this file.	QuLogic	Sept. 5, 2023, 2:47 a.m.
This should probably get a valign=center.	QuLogic	Sept. 5, 2023, 2:47 a.m.
Is this property supposed to be here with a mostly empty value?	QuLogic	Sept. 5, 2023, 2:47 a.m.
I think this is the default?	QuLogic	Sept. 5, 2023, 2:47 a.m.
Ditto	QuLogic	Sept. 5, 2023, 2:47 a.m.

Added Files:

Added Files:

Removed Files:

Added Files:

Removed Files:
Added Files:

pidgin/pidginconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/display/displaying
```
pidgin/pidginconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/only for display if/is only for display; if/
```

pidgin/pidginconversation.c (Diff revision 1)

The issue has been resolved. Show all issues

Do we need to clear this somewhere? Since the conversation property is construct-only, maybe only in dispose?

pidgin/pidginconversation.c (Diff revision 1)

The issue has been resolved. Show all issues

self is a bit of a confusing variable name for me, since that's not the class defined in this file.

pidgin/resources/Conversations/conversation.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
This should probably get a valign=center.
```

pidgin/resources/Conversations/conversation.ui (Diff revision 1)

The issue has been resolved. Show all issues

Is this property supposed to be here with a mostly empty value?

grim Aug. 29, 2023, 7:24 a.m.

nope, i started the bind here but ended up doing it later and forgot to delete this.

pidgin/resources/Conversations/conversation.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
I think this is the default?
```
pidgin/resources/Conversations/conversation.ui (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto
```

Change Summary:

rebase and address issues. I'm not 100% happy withe close stuff, but it works for now.

Commits:

	Summary	ID
	The start of the new conversation window	ba82012bbf6ab5e3cc8f0777dc0e838b4c8bf806
	The start of the new conversation window	01761f22665e36982495eb2dd5fc4fc2558b4724

Diff:

Revision 2 (+1006 -34)

Show changes

	pidgin/gtkconv.c
	pidgin/meson.build
	pidgin/pidginconversation.h
	pidgin/pidginconversation.c
	pidgin/pidgindisplaywindow.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Conversations/conversation.ui

Change Summary:

fix a link in the docs

Commits:

	Summary	ID
	The start of the new conversation window	01761f22665e36982495eb2dd5fc4fc2558b4724
	The start of the new conversation window	d6a7e08315ff9f2e42303d8be92dbd38c5869fde

Diff:

Revision 3 (+1006 -34)

Show changes

	pidgin/gtkconv.c
	pidgin/meson.build
	pidgin/pidginconversation.h
	pidgin/pidginconversation.c
	pidgin/pidgindisplaywindow.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Conversations/conversation.ui

Ship it!

```
Ship It!
```

Status:: Completed