Added Files: |
|---|
The start of the new conversation window
Review Request #2589 — Created Aug. 29, 2023 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| Reviewers | |
| pidgin | |
The start of the new conversation window
Sent some messages on XMPP and IRCv3.
| Summary |
|---|
| Description | From | Last Updated |
|---|---|---|
|
s/display/displaying |
 QuLogic
|
|
|
s/only for display if/is only for display; if/ |
QuLogic
|
|
|
Do we need to clear this somewhere? Since the conversation property is construct-only, maybe only in dispose? |
QuLogic
|
|
|
self is a bit of a confusing variable name for me, since that's not the class defined in this file. |
QuLogic
|
|
|
This should probably get a valign=center. |
QuLogic
|
|
|
Is this property supposed to be here with a mostly empty value? |
QuLogic
|
|
|
I think this is the default? |
QuLogic
|
|
|
Ditto |
QuLogic
|
-
-
-
-
pidgin/pidginconversation.c (Diff revision 1) Do we need to clear this somewhere? Since the conversation property is construct-only, maybe only in dispose?
-
pidgin/pidginconversation.c (Diff revision 1) selfis a bit of a confusing variable name for me, since that's not the class defined in this file. -
pidgin/resources/Conversations/conversation.ui (Diff revision 1) This should probably get a valign=center.
-
pidgin/resources/Conversations/conversation.ui (Diff revision 1) Is this property supposed to be here with a mostly empty value?
-
-
Change Summary:
rebase and address issues. I'm not 100% happy withe close stuff, but it works for now.
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1006 -34) |
Change Summary:
fix a link in the docs
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1006 -34) |