Create PurpleIdleManager for managing idle states

Review Request #2586 — Created Aug. 27, 2023 and updated Sept. 22, 2023, 3:04 a.m.

Information
Owner:	grim
Repository:	pidgin/pidgin
Branch:	default
Bugs:	PIDGIN-17818
Depends On:
Reviewers
Groups:	pidgin
People:

Description

Create PurpleIdleManager for managing idle states

Testing Done

Ran the unit tests

Commits

Summary
Create PurpleIdleManager for managing idle states

Screenshots

Issues

Description	From	Last Updated
s/idle_size/idle time/ ?	QuLogic	Sept. 5, 2023, 6:06 a.m.
Wrong comment.	QuLogic	Sept. 5, 2023, 6:06 a.m.
Outdated comment.	QuLogic	Sept. 5, 2023, 6:06 a.m.

Fix it!

I've found it a bit confusing to call it the "idle since" everywhere (and didn't comment in all places), since it seems like there should be some clause after "since". Maybe call it the "idle time" or "idle-since time" (note, I only mean for descriptions, not the name of the property)?

libpurple/purpleidlemanager.h (Diff revision 1)
Show all issues
```
s/idle_size/idle time/ ?
```
libpurple/purpleidlemanagerprivate.h (Diff revision 1)
Show all issues
```
Wrong comment.
```
libpurple/tests/test_idle_manager.c (Diff revision 1)
Show all issues
```
Outdated comment.
```

Change Summary:

Rebased, fixed issues, renamed idle-since to timestamp, and added a bunch more documentation.

Commits:

	Summary
-	Create PurpleIdleManager for managing idle states
+	Create PurpleIdleManager for managing idle states

Diff:

Revision 2 (+1130 -4)

Show changes

	libpurple/core.c
	libpurple/meson.build
	libpurple/purpleidlemanager.h
	libpurple/purpleidlemanager.c
	libpurple/purpleidlemanagerprivate.h
	libpurple/tests/meson.build
	libpurple/tests/test_idle_manager.c

You have a pending review.

Review Board 5.0.6

Create PurpleIdleManager for managing idle states

Change Summary:

Commits:

Diff: