Summary

Create PurpleIdleManager for managing idle states

Review Request #2586 — Created Aug. 27, 2023 and submitted Oct. 24, 2023, 3:09 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17818

Depends On

Reviewers

Groups

pidgin

People

Description

Create PurpleIdleManager for managing idle states

Testing Done

Ran the unit tests

Commits

Summary	ID
Create PurpleIdleManager for managing idle states	fda63c26d07db2fb643df5b76962b15b35df94b2

Issues

Description	From	Last Updated
s/idle_size/idle time/ ?	QuLogic	Oct. 24, 2023, 2:12 a.m.
Wrong comment.	QuLogic	Oct. 24, 2023, 1:55 a.m.
Outdated comment.	QuLogic	Oct. 24, 2023, 1:55 a.m.
used as	QuLogic	Oct. 24, 2023, 2:50 a.m.
they would choose	QuLogic	Oct. 24, 2023, 2:50 a.m.
s/so/then/	QuLogic	Oct. 24, 2023, 2:50 a.m.
s/obscene/exagerrated/ or similar?	QuLogic	Oct. 24, 2023, 2:50 a.m.
Don't need the semicolon, usually.	QuLogic	Oct. 24, 2023, 2:50 a.m.
Extra blank line?	QuLogic	Oct. 24, 2023, 2:50 a.m.
Wrong alignment.	QuLogic	Oct. 24, 2023, 2:50 a.m.
s/an timestamp/a timestamp/	QuLogic	Oct. 24, 2023, 2:50 a.m.

I've found it a bit confusing to call it the "idle since" everywhere (and didn't comment in all places), since it seems like there should be some clause after "since". Maybe call it the "idle time" or "idle-since time" (note, I only mean for descriptions, not the name of the property)?

libpurple/purpleidlemanager.h (Diff revision 1)
Show all issues
```
s/idle_size/idle time/ ?
```
libpurple/purpleidlemanagerprivate.h (Diff revision 1)
Show all issues
```
Wrong comment.
```
libpurple/tests/test_idle_manager.c (Diff revision 1)
Show all issues
```
Outdated comment.
```

Change Summary:

Rebased, fixed issues, renamed idle-since to timestamp, and added a bunch more documentation.

Commits:

	Summary	ID
	Create PurpleIdleManager for managing idle states	a0d2e938e79f5d3f57a88fbe22f76fa45e977c42
	Create PurpleIdleManager for managing idle states	a4e2a058bc39f4958bbcc7febe231256dcc59c5f

Diff:

Revision 2 (+1130 -4)

Show changes

	libpurple/core.c
	libpurple/meson.build
	libpurple/purpleidlemanager.h
	libpurple/purpleidlemanager.c
	libpurple/purpleidlemanagerprivate.h
	libpurple/tests/meson.build
	libpurple/tests/test_idle_manager.c

Change Summary:

rebased

Commits:

	Summary	ID
	Create PurpleIdleManager for managing idle states	a4e2a058bc39f4958bbcc7febe231256dcc59c5f
	Create PurpleIdleManager for managing idle states	2bdad38c18abff9619d83c1456084de5fec5c5af

Diff:

Revision 3 (+1130 -4)

Show changes

	libpurple/core.c
	libpurple/meson.build
	libpurple/purpleidlemanager.h
	libpurple/purpleidlemanager.c
	libpurple/purpleidlemanagerprivate.h
	libpurple/tests/meson.build
	libpurple/tests/test_idle_manager.c

Change Summary:

rebased

Commits:

	Summary	ID
	Create PurpleIdleManager for managing idle states	2bdad38c18abff9619d83c1456084de5fec5c5af
	Create PurpleIdleManager for managing idle states	a6f7f9da826790340aa05f19d76398ad214bc5df

Diff:

Revision 4 (+1130 -4)

Show changes

	libpurple/core.c
	libpurple/meson.build
	libpurple/purpleidlemanager.h
	libpurple/purpleidlemanager.c
	libpurple/purpleidlemanagerprivate.h
	libpurple/tests/meson.build
	libpurple/tests/test_idle_manager.c

libpurple/purpleidlemanager.h (Diff revision 4)
Show all issues
```
used as
```
libpurple/purpleidlemanager.h (Diff revision 4)
Show all issues
```
they would choose
```
libpurple/purpleidlemanager.h (Diff revision 4)
Show all issues
```
s/so/then/
```
libpurple/purpleidlemanager.h (Diff revision 4)
Show all issues
```
s/obscene/exagerrated/ or similar?
```
libpurple/purpleidlemanager.c (Diff revision 4)
Show all issues
```
Don't need the semicolon, usually.
```
libpurple/purpleidlemanager.c (Diff revision 4)
Show all issues
```
Extra blank line?
```
libpurple/tests/test_idle_manager.c (Diff revision 4)
Show all issues
```
Wrong alignment.
```
libpurple/tests/test_idle_manager.c (Diff revision 4)
Show all issues
```
s/an timestamp/a timestamp/
```

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Create PurpleIdleManager for managing idle states	a6f7f9da826790340aa05f19d76398ad214bc5df
	Create PurpleIdleManager for managing idle states	fda63c26d07db2fb643df5b76962b15b35df94b2

Diff:

Revision 5 (+1128 -4)

Show changes

	libpurple/core.c
	libpurple/meson.build
	libpurple/purpleidlemanager.h
	libpurple/purpleidlemanager.c
	libpurple/purpleidlemanagerprivate.h
	libpurple/tests/meson.build
	libpurple/tests/test_idle_manager.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Create PurpleIdleManager for managing idle states

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)