Create PurpleIdleManager for managing idle states

Review Request #2586 — Created Aug. 27, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Create PurpleIdleManager for managing idle states

Ran the unit tests

Summary ID
Create PurpleIdleManager for managing idle states
fda63c26d07db2fb643df5b76962b15b35df94b2
Description From Last Updated

s/idle_size/idle time/ ?

QuLogicQuLogic

Wrong comment.

QuLogicQuLogic

Outdated comment.

QuLogicQuLogic

used as

QuLogicQuLogic

they would choose

QuLogicQuLogic

s/so/then/

QuLogicQuLogic

s/obscene/exagerrated/ or similar?

QuLogicQuLogic

Don't need the semicolon, usually.

QuLogicQuLogic

Extra blank line?

QuLogicQuLogic

Wrong alignment.

QuLogicQuLogic

s/an timestamp/a timestamp/

QuLogicQuLogic
QuLogic
  1. I've found it a bit confusing to call it the "idle since" everywhere (and didn't comment in all places), since it seems like there should be some clause after "since". Maybe call it the "idle time" or "idle-since time" (note, I only mean for descriptions, not the name of the property)?

  2. libpurple/purpleidlemanager.h (Diff revision 1)
     
     
    Show all issues

    s/idle_size/idle time/ ?

  3. libpurple/purpleidlemanagerprivate.h (Diff revision 1)
     
     
    Show all issues

    Wrong comment.

  4. libpurple/tests/test_idle_manager.c (Diff revision 1)
     
     
    Show all issues

    Outdated comment.

  5. 
      
grim
grim
grim
QuLogic
  1. 
      
  2. libpurple/purpleidlemanager.h (Diff revision 4)
     
     
    Show all issues

    used as

  3. libpurple/purpleidlemanager.h (Diff revision 4)
     
     
    Show all issues

    they would choose

  4. libpurple/purpleidlemanager.h (Diff revision 4)
     
     
    Show all issues

    s/so/then/

  5. libpurple/purpleidlemanager.h (Diff revision 4)
     
     
    Show all issues

    s/obscene/exagerrated/ or similar?

  6. libpurple/purpleidlemanager.c (Diff revision 4)
     
     
    Show all issues

    Don't need the semicolon, usually.

  7. libpurple/purpleidlemanager.c (Diff revision 4)
     
     
     
     
    Show all issues

    Extra blank line?

  8. libpurple/tests/test_idle_manager.c (Diff revision 4)
     
     
     
     
    Show all issues

    Wrong alignment.

  9. libpurple/tests/test_idle_manager.c (Diff revision 4)
     
     
    Show all issues

    s/an timestamp/a timestamp/

  10. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed