-
-
-
libpurple/protocols/ircv3/purpleircv3source.c (Diff revision 1) Should this be anchored, or use
match_full
? -
libpurple/protocols/ircv3/tests/test_ircv3_source.c (Diff revision 1) Tests seem to only be for happy path; wondering what is expected for invalid unparseable input?
IRCv3: add ircv3_source_parse to parse sources into nick, user, and host
Review Request #2585 — Created Aug. 23, 2023 and submitted
IRCv3: add ircv3_source_parse to parse sources into nick, user, and host
Ran the unit tests under valgrind
Change Summary:
address issues
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+566) |
Change Summary:
rebased
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+566) |
Change Summary:
tweaked the regex to not allow
!
and@
in servernames and added a few more bad example unit tests.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+596) |