Summary

Make the purple_account_manager_find functions return transfer full.

Review Request #2579 — Created Aug. 21, 2023 and submitted Aug. 22, 2023, 12:25 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

It's possible that an account could be removed from the mananger after someone
has grabbed a handle to one, so just give them a reference to avoid the
possible headache later.

Testing Done

Ran the account-manager tests under valgrind.

Commits

Summary	ID
Make the purple_account_manager_find functions return transfer full. It's possible that an account could be removed from the mananger after someone has grabbed a handle to one, so just give them a reference to avoid the possible headache later.	131d55709d51aa5baf28a5f4e72ed52a34f7c569

Issues

Description	From	Last Updated
find_acct in libpurple/protocols/jabber/jabber.c conditionally leaks acct.	QuLogic	Aug. 22, 2023, 12:16 a.m.
There's an early return in this function that leaks account.	QuLogic	Aug. 22, 2023, 12:16 a.m.
There's an early return in this function that leaks account.	QuLogic	Aug. 22, 2023, 12:16 a.m.
Should use free_saved_status_sub as well.	QuLogic	Aug. 22, 2023, 12:17 a.m.
This should probably be using free_saved_status_sub instead (and that should get the g_clear_object).	QuLogic	Aug. 22, 2023, 12:17 a.m.
There's another purple_account_manager_find* above this that is non-NULL.	QuLogic	Aug. 22, 2023, 12:18 a.m.

The issue has been resolved. Show all issues

find_acct in libpurple/protocols/jabber/jabber.c conditionally leaks acct.

libpurple/buddylist.c (Diff revision 1)
The issue has been resolved. Show all issues
```
There's an early return in this function that leaks account.
```
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
There's an early return in this function that leaks account.
```
libpurple/savedstatuses.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use free_saved_status_sub as well.
```

libpurple/savedstatuses.c (Diff revision 1)

The issue has been resolved. Show all issues

This should probably be using free_saved_status_sub instead (and that should get the g_clear_object).

libpurple/tests/test_account_manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
There's another purple_account_manager_find* above this that is non-NULL.
```

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Make the purple_account_manager_find functions return transfer full. It's possible that an account could be removed from the mananger after someone has grabbed a handle to one, so just give them a reference to avoid the possible headache later.	eb20922244ce8fc5e0ec76ae3209b918ab3e38cc
	Make the purple_account_manager_find functions return transfer full. It's possible that an account could be removed from the mananger after someone has grabbed a handle to one, so just give them a reference to avoid the possible headache later.	131d55709d51aa5baf28a5f4e72ed52a34f7c569

Diff:

Revision 2 (+136 -30)

Show changes

	libpurple/buddylist.c
	libpurple/purpleaccountmanager.h
	libpurple/purpleaccountmanager.c
	libpurple/savedstatuses.c
	libpurple/protocols/demo/purpledemoprotocolactions.c
	libpurple/protocols/gg/gg.c
	libpurple/protocols/jabber/buddy.c
	libpurple/protocols/jabber/jabber.c
	4 more

Ship it!

```
Ship It!
```

Status:: Completed