-
-
-
libpurple/buddylist.c (Diff revision 1) There's an early return in this function that leaks
account. -
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1) There's an early return in this function that leaks
account. -
-
libpurple/savedstatuses.c (Diff revision 1) This should probably be using
free_saved_status_subinstead (and that should get theg_clear_object). -
libpurple/tests/test_account_manager.c (Diff revision 1) There's another
purple_account_manager_find*above this that is non-NULL.
Make the purple_account_manager_find functions return transfer full.
Review Request #2579 — Created Aug. 21, 2023 and submitted
It's possible that an account could be removed from the mananger after someone has grabbed a handle to one, so just give them a reference to avoid the possible headache later.
Ran the account-manager tests under valgrind.
| Summary | ID |
|---|---|
| 131d55709d51aa5baf28a5f4e72ed52a34f7c569 |
| Description | From | Last Updated |
|---|---|---|
|
find_acct in libpurple/protocols/jabber/jabber.c conditionally leaks acct. |
 QuLogic
|
|
|
There's an early return in this function that leaks account. |
QuLogic
|
|
|
There's an early return in this function that leaks account. |
QuLogic
|
|
|
Should use free_saved_status_sub as well. |
QuLogic
|
|
|
This should probably be using free_saved_status_sub instead (and that should get the g_clear_object). |
QuLogic
|
|
|
There's another purple_account_manager_find* above this that is non-NULL. |
QuLogic
|
Change Summary:
rebased and addressed issues
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+136 -30) |