Add virtual functions for actions and menu to PurpleProtocolContacts

Review Request #2578 — Created Aug. 20, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Add virtual functions for actions and menu to PurpleProtocolContacts

Ran the unit tests.

Summary ID
Add virtual functions for actions and menu to PurpleProtocolContacts
dcca74a6dbfc939aaf2dab80a04aa8a87fb590bf
Description From Last Updated

Do you need test at the end of these function names again?

QuLogicQuLogic

Ah, I see, the others can avoid that since they have _async/_finish suffixes in the implementation. Maybe use a _normal …

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/tests/test_protocol_contacts.c (Diff revision 1)
     
     
     
     
     
    Show all issues

    Do you need test at the end of these function names again?

    1. Yeah, because TestPurpleProtocolContacts uses the name with the _test for the implementations. If you have some other suggestions, I'm open to them :)

  3. 
      
QuLogic
  1. 
      
  2. libpurple/tests/test_protocol_contacts.c (Diff revision 1)
     
     
     
     
     
    Show all issues

    Ah, I see, the others can avoid that since they have _async/_finish suffixes in the implementation.

    Maybe use a _normal suffix as in the get_profile test?

    1. Sorry, that was supposed to be a reply.

    2. That's a great idea!

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed