Summary

Add virtual functions for actions and menu to PurpleProtocolContacts

Review Request #2578 — Created Aug. 20, 2023 and submitted Aug. 29, 2023, 3:57 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17682

Depends On

~~2577~~

Reviewers

Groups

pidgin

People

Description

Add virtual functions for actions and menu to PurpleProtocolContacts

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add virtual functions for actions and menu to PurpleProtocolContacts	dcca74a6dbfc939aaf2dab80a04aa8a87fb590bf

Issues

Description	From	Last Updated
Do you need test at the end of these function names again?	QuLogic	Aug. 29, 2023, 2:59 a.m.
Ah, I see, the others can avoid that since they have _async/_finish suffixes in the implementation. Maybe use a _normal …	QuLogic	Aug. 29, 2023, 2:59 a.m.

libpurple/tests/test_protocol_contacts.c (Diff revision 1)

The issue has been resolved. Show all issues

Do you need test at the end of these function names again?

grim Aug. 27, 2023, 8:54 a.m.

Yeah, because TestPurpleProtocolContacts uses the name with the _test for the implementations. If you have some other suggestions, I'm open to them :)

libpurple/tests/test_protocol_contacts.c (Diff revision 1)

The issue has been resolved. Show all issues

Ah, I see, the others can avoid that since they have _async/_finish suffixes in the implementation.

Maybe use a _normal suffix as in the get_profile test?

QuLogic Aug. 29, 2023, 2:05 a.m.
```
Sorry, that was supposed to be a reply.
```
grim Aug. 29, 2023, 2:48 a.m.
```
That's a great idea!
```

Change Summary:

rebase and make crappy test names less crappy

Commits:

	Summary	ID
	Add virtual functions for actions and menu to PurpleProtocolContacts	3cd5a54a82735238994105db2767a4cd2ed47a3c
	Add virtual functions for actions and menu to PurpleProtocolContacts	dcca74a6dbfc939aaf2dab80a04aa8a87fb590bf

Diff:

Revision 2 (+336 -4)

Show changes

	libpurple/purpleprotocolcontacts.h
	libpurple/purpleprotocolcontacts.c
	libpurple/tests/test_protocol_contacts.c

Ship it!

```
Ship It!
```

Status:: Completed