Reviews
Diff

- Download Diff

Summary:

Add a bunch of properties to PurpleConversation

Review Request #2576 — Created Aug. 18, 2023 and submitted Aug. 22, 2023, 7:06 a.m.

Information
Owner:	grim
Repository:	pidgin/pidgin
Branch:	default
Bugs:	PIDGIN-17824
Depends On:
Reviewers
Groups:	pidgin
People:

Description

Add a bunch of properties to PurpleConversation

Testing Done

Ran all the unit tests and joined and xmpp muc and sent some messages.

Commits

Summary
	Add a bunch of properties to PurpleConversation

Screenshots

Issues

Description	From	Last Updated
s/-/ /	QuLogic	Aug. 22, 2023, 5:29 a.m.
s/-/ / Trailing \.	QuLogic	Aug. 22, 2023, 5:30 a.m.
s/created on/creation time/	QuLogic	Aug. 22, 2023, 5:30 a.m.
s/-/ /	QuLogic	Aug. 22, 2023, 5:30 a.m.
s/FALSE/NULL/	QuLogic	Aug. 22, 2023, 5:30 a.m.
s/FALSE/NULL/	QuLogic	Aug. 22, 2023, 5:30 a.m.
s/FALSE/NULL/	QuLogic	Aug. 22, 2023, 5:30 a.m.
s/FALSE/NULL/	QuLogic	Aug. 22, 2023, 5:31 a.m.
s/FALSE/NULL/	QuLogic	Aug. 22, 2023, 5:31 a.m.

libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
s/-/ /
```
libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
s/-/ /
Trailing \.
```
libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
s/created on/creation time/
```
libpurple/purpleconversation.h (Diff revision 1)
Show all issues
```
s/-/ /
```
libpurple/purpleconversation.c (Diff revision 1)
Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
Show all issues
```
s/FALSE/NULL/
```

Change Summary:

rebase and address issues

Commits:

	Summary
-		Add a bunch of properties to PurpleConversation
+		Add a bunch of properties to PurpleConversation

Diff:

Revision 2 (+1682 -46)

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Loading...