Summary

Add a bunch of properties to PurpleConversation

Review Request #2576 — Created Aug. 18, 2023 and submitted Aug. 22, 2023, 7:06 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Add a bunch of properties to PurpleConversation

Testing Done

Ran all the unit tests and joined and xmpp muc and sent some messages.

Commits

Summary	ID
Add a bunch of properties to PurpleConversation A few of these duplicate stuff in PurpleChatConversation but those will be migrated to these new properties in a short manner.	d605bdc00487e2ca39199e2d36ac8aa88ae06083

Issues

libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/-/ /
```
libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/-/ /
Trailing \.
```
libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/created on/creation time/
```
libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/-/ /
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/FALSE/NULL/
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/FALSE/NULL/
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Add a bunch of properties to PurpleConversation A few of these duplicate stuff in PurpleChatConversation but those will be migrated to these new properties in a short manner.	a1d6c502cbcefb4ba48ef5c95033b1f4f1aa93c7
	Add a bunch of properties to PurpleConversation A few of these duplicate stuff in PurpleChatConversation but those will be migrated to these new properties in a short manner.	d605bdc00487e2ca39199e2d36ac8aa88ae06083

Diff:

Revision 2 (+1682 -46)

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/test_conversation.c

Ship it!