Add a connected property to PurpleAccount so bindings can use it

Review Request #2542 — Created Aug. 4, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

While fixing some bugs in the account editor, I ended up manually settings some
widgets sensitivity depending on an account being connected. However this
easily gets out of sync if the editor is open and an account switches online
states. With this property we will be able to bind and not fall out of sync.

Compiled

Summary ID
Add a connected property to PurpleAccount so bindings can use it
While fixing some bugs in the account editor, I ended up manually settings some widgets sensitivity depending on an account being connected. However this easily gets out of sync if the editor is open and an account switches online states. With this property we will be able to bind and not fall out of sync.
6d1cf922098d185a18b391191205a7edce2496da
Description From Last Updated

Should we also/instead have a state property? Something with enum disconnected/connecting/connected?

QuLogicQuLogic
QuLogic
  1. 
      
  2. Should we also/instead have a state property? Something with enum disconnected/connecting/connected?

    1. Yes, but adding this will get ugly because there's a bunch of stuff already tied to the connection's state that will need to be adjust/removed as part of adding an account state. Therefore we should do that in another pull request.

  3. 
      
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...