Summary

Fix a number of bugs in the account editor

Review Request #2540 — Created Aug. 4, 2023 and submitted Aug. 4, 2023, 5:29 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17813

Depends On

Reviewers

Groups

pidgin

People

Description

This fixes the protocol not being the first one in the list as well as the
username still being populate from a previous account when a new account is
being created.

All login options are now set to insensitive when an account is online and are
properly made sensitive when the account is offline. However, these properties
aren't bound yet, because there's no property to bind to. See PIDGIN-17815.

Testing Done

Opened the account editor for an existing online account and verified that the protocol, username, and all user splits were insensitive. Hit the back button, hit the add button and verified that the protocol was at Bonjour (the first in the list) and that the username was empty and that those 2 and all of the user splits were sensitive.

Commits

Summary	ID
Fix a number of bugs in the account editor This fixes the protocol not being the first one in the list as well as the username still being populate from a previous account when a new account is being created. All login options are now set to insensitive when an account is online and are properly made sensitive when the account is offline. However, these properties aren't bound yet, because there's no property to bind to. See PIDGIN-17815.	7460ad45b61a271353c8a5816084742fa0d77445

Summary

Fix a number of bugs in the account editor

This fixes the protocol not being the first one in the list as well as the username still being populate from a previous account when a new account is being created. All login options are now set to insensitive when an account is online and are properly made sensitive when the account is offline. However, these properties aren't bound yet, because there's no property to bind to. See PIDGIN-17815.

7460ad45b61a271353c8a5816084742fa0d77445

Issues

Description	From	Last Updated
Should we have show_overview call set_account(editor, NULL and not do it in both places?	QuLogic	Aug. 4, 2023, 5:19 a.m.
Minor thing; I'd change the stack first so that the editor doesn't appear to clear before hiding (though I'm pretty …	QuLogic	Aug. 4, 2023, 5:28 a.m.

pidgin/pidginaccountmanager.c (Diff revision 1)

Show all issues

Should we have show_overview call set_account(editor, NULL and not do it in both places?

grim Aug. 4, 2023, 4:49 a.m.
```
yeah that makes a lot of sense.
```

Change Summary:

set the editor's account to null when we show the overview page in the manager.

Commits:

	Summary	ID
	Fix a number of bugs in the account editor This fixes the protocol not being the first one in the list as well as the username still being populate from a previous account when a new account is being created. All login options are now set to insensitive when an account is online and are properly made sensitive when the account is offline. However, these properties aren't bound yet, because there's no property to bind to. See PIDGIN-17815.	a0c1558b4e5df1e2b5dc63d5b76153627ab42bf5
	Fix a number of bugs in the account editor This fixes the protocol not being the first one in the list as well as the username still being populate from a previous account when a new account is being created. All login options are now set to insensitive when an account is online and are properly made sensitive when the account is offline. However, these properties aren't bound yet, because there's no property to bind to. See PIDGIN-17815.	d8bf594a7d0c5e5eff811aebcad038324cb93c4d

Diff:

Revision 2 (+88 -48)

Show changes

	pidgin/pidginaccounteditor.c
	pidgin/pidginaccountmanager.c

Ship it!

```
Ship It!
```

pidgin/pidginaccountmanager.c (Diff revision 2)

Show all issues

Minor thing; I'd change the stack first so that the editor doesn't appear to clear before hiding (though I'm pretty sure at this point, nothing runs the event loop, so it shouldn't do that, but just in case that changes in the future.)

Change Summary:

switch the stack before nulling out the account.

Commits:

	Summary	ID
	Fix a number of bugs in the account editor This fixes the protocol not being the first one in the list as well as the username still being populate from a previous account when a new account is being created. All login options are now set to insensitive when an account is online and are properly made sensitive when the account is offline. However, these properties aren't bound yet, because there's no property to bind to. See PIDGIN-17815.	d8bf594a7d0c5e5eff811aebcad038324cb93c4d
	Fix a number of bugs in the account editor This fixes the protocol not being the first one in the list as well as the username still being populate from a previous account when a new account is being created. All login options are now set to insensitive when an account is online and are properly made sensitive when the account is offline. However, these properties aren't bound yet, because there's no property to bind to. See PIDGIN-17815.	7460ad45b61a271353c8a5816084742fa0d77445

Diff:

Revision 3 (+88 -48)

Show changes

	pidgin/pidginaccounteditor.c
	pidgin/pidginaccountmanager.c

Review Board 6.0.2

Fix a number of bugs in the account editor

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)