Summary

Remove the notify plugin

Review Request #2537 — Created Aug. 1, 2023 and submitted Aug. 8, 2023, 4:20 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This hasn't been building by default for a while and depends on a whole bunch
of old conversation window api that it is the only consumer of. Also most people
nowadays are used to just getting a badge which is what we're planning on doing in
the near future. For all these reasons, we should just delete this.

Testing Done

Ran ninja turtles without issue.

Commits

Summary	ID
Remove the notify plugin This hasn't been building by default for awhile and depends on a whole bunch of old conversation window api that it is the only consume of. Also most people nowadays are used to just getting a badge which what we're planning on doing in the near future. For all these reasons, we should just delete this.	31c18400ac2c0b40e104993dc5200cad0fa57745

Change Summary:

Fix typos.

Description:

~		This hasn't been building by default for awhile and depends on a whole bunch
~		of old conversation window api that it is the only consume of. Also most people
~		nowadays are used to just getting a badge which what we're planning on doing in
	~	This hasn't been building by default for a while and depends on a whole bunch
	~	of old conversation window api that it is the only consumer of. Also most people
	~	nowadays are used to just getting a badge which is what we're planning on doing in
		the near future. For all these reasons, we should just delete this.

Ship it!

```
Ship It!
```

Change Summary:

rebased

Commits:

	Summary	ID
	Remove the notify plugin This hasn't been building by default for awhile and depends on a whole bunch of old conversation window api that it is the only consume of. Also most people nowadays are used to just getting a badge which what we're planning on doing in the near future. For all these reasons, we should just delete this.	b457124662dd0f96417dff22e6e0b763951bd44f
	Remove the notify plugin This hasn't been building by default for awhile and depends on a whole bunch of old conversation window api that it is the only consume of. Also most people nowadays are used to just getting a badge which what we're planning on doing in the near future. For all these reasons, we should just delete this.	31c18400ac2c0b40e104993dc5200cad0fa57745

Diff:

Revision 2 (-2272)

Show changes

	pidgin/plugins/meson.build
	pidgin/plugins/notify/im.pidgin.Pidgin.plugin.Notify.gschema.xml
	pidgin/plugins/notify/meson.build
	pidgin/plugins/notify/notify.c
	po/POTFILES.in

Review Board 6.0.2

Remove the notify plugin

Information

Reviewers

Change Summary:

Description:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)