Summary

Add some additional fields to PurpleContactInfo

Review Request #2534 — Created July 26, 2023 and submitted Aug. 4, 2023, 9:26 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17812

Depends On

Reviewers

Groups

pidgin

People

Description

Add some additional fields to PurpleContactInfo

Testing Done

Ran the unit tests with the valgrind wrapper

Commits

Summary	ID
Add some additional fields to PurpleContactInfo	cdeddde37565b4dbb7bd941e2de5564dfe00eb4c

Issues

Description	From	Last Updated
Since this isn't a const char, should it have a (transfer none)?	QuLogic	Aug. 4, 2023, 5:50 a.m.
And same here?	QuLogic	Aug. 4, 2023, 5:50 a.m.

Change Summary:

add time-zone and note properties

Description:

~		"email" is intended to hold the primary email address if one is available.
	~	Add some additional fields to PurpleContactInfo
-		"phone-number" is intended to hold the primary phone number if one is available.

Commits:

	Summary	ID
	Add some additional fields to PurpleContactInfo * "email" is intended to hold the primary email address if one is available. * "phone-number" is intended to hold the primary phone number if one is available.	698935adb38ad3fdf9a8693d2a408b5c17eda034
	Add some additional fields to PurpleContactInfo	b229c2a100eb2469125b8cb06ebc0050734f6473

Diff:

Revision 2 (+664 -4)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/tests/test_contact_info.c

Change Summary:

fix a link in the docs

Commits:

	Summary	ID
	Add some additional fields to PurpleContactInfo	b229c2a100eb2469125b8cb06ebc0050734f6473
	Add some additional fields to PurpleContactInfo	a250e7d60f02338c3196d9b9c9fff3befb71c71f

Diff:

Revision 3 (+664 -4)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/tests/test_contact_info.c

libpurple/purplecontactinfo.h (Diff revision 3)
Show all issues
```
Since this isn't a const char, should it have a (transfer none)?
```
1. grim Aug. 4, 2023, 5:36 a.m.
  Nice catch!
libpurple/purplecontactinfo.h (Diff revision 3)
Show all issues
```
And same here?
```
1. grim Aug. 4, 2023, 5:36 a.m.
  Good Catch!

Change Summary:

add missing transfer annotations

Commits:

	Summary	ID
	Add some additional fields to PurpleContactInfo	a250e7d60f02338c3196d9b9c9fff3befb71c71f
	Add some additional fields to PurpleContactInfo	cdeddde37565b4dbb7bd941e2de5564dfe00eb4c

Diff:

Revision 4 (+664 -4)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/tests/test_contact_info.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add some additional fields to PurpleContactInfo

Information

Reviewers

Change Summary:

Description:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)