Add PurpleProtocolContactSearchInterface to search for contacts

Review Request #2533 — Created July 25, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This interface is meant for you to be able to search for new contacts to add to
your contact list. Right now this just does keyword search, but can be extended
in the future.

Searching through your contact list is the ui's responsibility.

Ran the unit tests

Summary ID
Add PurpleProtocolContactSearchInterface to search for contacts
This interface is meant for you to be able to search for new contacts to add to your contact list. Right now this just does keyword search, but can be extended in the future. Searching through your contact list is the ui's responsibility.
d73947303d567a56bddc217e0e16878bbd43721c
Description From Last Updated

Add note it cannot be empty.

QuLogicQuLogic

This variable can be moved into the first if, unless you want to change things around to return ret at …

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/purpleprotocolcontactsearch.h (Diff revision 1)
     
     
    Show all issues

    Add note it cannot be empty.

  3. libpurple/purpleprotocolcontactsearch.c (Diff revision 1)
     
     
    Show all issues

    This variable can be moved into the first if, unless you want to change things around to return ret at the end instead of the early return.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed