Summary

Add PurpleProtocolContactSearchInterface to search for contacts

Review Request #2533 — Created July 25, 2023 and submitted Aug. 8, 2023, 4:22 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This interface is meant for you to be able to search for new contacts to add to
your contact list. Right now this just does keyword search, but can be extended
in the future.

Searching through your contact list is the ui's responsibility.

Testing Done

Ran the unit tests

Commits

Summary	ID
Add PurpleProtocolContactSearchInterface to search for contacts This interface is meant for you to be able to search for new contacts to add to your contact list. Right now this just does keyword search, but can be extended in the future. Searching through your contact list is the ui's responsibility.	d73947303d567a56bddc217e0e16878bbd43721c

Issues

Description	From	Last Updated
Add note it cannot be empty.	QuLogic	Aug. 8, 2023, 4:01 a.m.
This variable can be moved into the first if, unless you want to change things around to return ret at …	QuLogic	Aug. 8, 2023, 4:01 a.m.

libpurple/purpleprotocolcontactsearch.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Add note it cannot be empty.
```

libpurple/purpleprotocolcontactsearch.c (Diff revision 1)

The issue has been resolved. Show all issues

This variable can be moved into the first if, unless you want to change things around to return ret at the end instead of the early return.

Change Summary:

address issues

Commits:

	Summary	ID
	Add PurpleProtocolContactSearchInterface to search for contacts This interface is meant for you to be able to search for new contacts to add to your contact list. Right now this just does keyword search, but can be extended in the future. Searching through your contact list is the ui's responsibility.	5f8594031ddae754a2de3931c332abc452cac850
	Add PurpleProtocolContactSearchInterface to search for contacts This interface is meant for you to be able to search for new contacts to add to your contact list. Right now this just does keyword search, but can be extended in the future. Searching through your contact list is the ui's responsibility.	d73947303d567a56bddc217e0e16878bbd43721c

Diff:

Revision 2 (+1068)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolcontactsearch.h
	libpurple/purpleprotocolcontactsearch.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_contact_search.c

Ship it!

```
Ship It!
```

Status:: Completed