Summary

Fix some issues with the PLAIN mechanism

Review Request #2506 — Created July 9, 2023 and submitted July 14, 2023, 7:04 a.m.

Information

Owner

grim

Repository

hasl/hasl

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Fix some issues with the PLAIN mechanism

Testing Done

Ran the unit tests and verified the docs.

Commits

Summary	ID
Fix some issues with the PLAIN mechanism	fe7268b7be205e1cd45f85cc6552e089e040fcf6

Change Summary:

Tweaked the doc string.

Commits:

	Summary	ID
	Fix some issues with the PLAIN mechanism	ef1799ae0d35d1575a24ef42e7f0913a829929b1
	Fix some issues with the PLAIN mechanism	87f18a2cc7fe637843564f8dcf0318f00e8b9803

Diff:

Revision 2 (+96 -30)

Show changes

	hasl/haslmechanismplain.h
	hasl/haslmechanismplain.c
	hasl/tests/test-mechanism-plain.c

Change Summary:

fix the doc comments, again...

Commits:

	Summary	ID
	Fix some issues with the PLAIN mechanism	87f18a2cc7fe637843564f8dcf0318f00e8b9803
	Fix some issues with the PLAIN mechanism	f6cb9386a7b57feb8ae5bc94d79800111f0fa4e8

Diff:

Revision 3 (+96 -30)

Show changes

	hasl/haslmechanismplain.h
	hasl/haslmechanismplain.c
	hasl/tests/test-mechanism-plain.c

Change Summary:

we should be using g_set_error_literal here as well especially as these strings are translated.

Commits:

	Summary	ID
	Fix some issues with the PLAIN mechanism	f6cb9386a7b57feb8ae5bc94d79800111f0fa4e8
	Fix some issues with the PLAIN mechanism	fe7268b7be205e1cd45f85cc6552e089e040fcf6

Diff:

Revision 4 (+108 -42)

Show changes

	hasl/haslmechanismplain.h
	hasl/haslmechanismplain.c
	hasl/tests/test-mechanism-plain.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Fix some issues with the PLAIN mechanism

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)