Summary

Add haslversion.h and all of its friends

Review Request #2504 — Created July 8, 2023 and submitted July 14, 2023, 6:56 a.m.

Information

Owner

grim

Repository

hasl/hasl

Branch

default

Bugs

HASL-3

Depends On

Reviewers

Groups

pidgin

People

Description

Add haslversion.h and all of its friends

Testing Done

Ran the unit tests.

I also tried defining G_DISABLE_ASSERT but that disables all unit tests so the line from g_assert_not_reached about not using it in unit tests is out of date.

Commits

Summary	ID
Add haslversion.h and all of its friends	3123ea436a72ab9523e400a403720fd9fed4bac1

Issues

Description	From	Last Updated
s/minor/micro	ivanhoe	July 13, 2023, 11:52 a.m.
micros	QuLogic	July 18, 2023, 3:29 a.m.
Not really a problem, but the version check macros are used in an unusual order. We might want to move …	belgin	July 14, 2023, 6:55 a.m.

hasl/haslversion.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/minor/micro
```

Change Summary:

fix typo

Commits:

	Summary	ID
	Add haslversion.h and all of its friends	f608a393f3c5bb988231ff9ee00947aa6591c0b0
	Add haslversion.h and all of its friends	4c13eee574a1b5cf71aedacb9abb113ab2e88698

Diff:

Revision 2 (+752)

Show changes

	hasl/haslversion.h
	hasl/haslversion.c
	hasl/haslversionconsts.h.in
	hasl/meson.build
	hasl/tests/meson.build
	hasl/tests/test-version.c

hasl/tests/test-version.c (Diff revision 2)

The issue has been resolved. Show all issues

Not really a problem, but the version check macros are used in an unusual order. We might want to move them around so they all are in a single order (e.g. -1 0 +1)

Change Summary:

make sure the compile time checks are in an consistent order.

Commits:

	Summary	ID
	Add haslversion.h and all of its friends	4c13eee574a1b5cf71aedacb9abb113ab2e88698
	Add haslversion.h and all of its friends	3123ea436a72ab9523e400a403720fd9fed4bac1

Diff:

Revision 3 (+752)

Show changes

	hasl/haslversion.h
	hasl/haslversion.c
	hasl/haslversionconsts.h.in
	hasl/meson.build
	hasl/tests/meson.build
	hasl/tests/test-version.c

Ship it!

```
Ship It!
```

Status:: Completed

Fix it!

hasl/tests/test-version.c (Diff revision 1)
An issue was opened. Show all issues
```
micros
```