Add gobject-introspection for ircv3
Review Request #2484 — Created June 22, 2023 and submitted
This includes a pkgconfig file and installs the header files as well as
purpleircv3.h to ${prefix}/include/purple-3/libpurple/protocols/ircv3.
This does not yet include the documentation as I assume that's going to touch
a bunch of files.
Compiled against gplugin 0.41.0 locally without issue. Also installed to a local prefix and verified everything looked okie dokie.
| Summary | ID |
|---|---|
| 721da2b91db496aaffcca019685a159973b1ef29 |
| Description | From | Last Updated |
|---|---|---|
|
I'm getting some new build warnings with this patch: During meson setup: libpurple/protocols/ircv3/meson.build:55: WARNING: Project targets '>=0.58.0' but uses feature … |
 ivanhoe
|
|
|
Where does purpleircv3.h.in come from? |
ivanhoe
|
|
|
The version needs to updated in the top level meson.build as well. |
ivanhoe
|
Change Summary:
add purpleircv3.h.in which I forgot to commit the first time.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+434 -52) |
-
-
I'm getting some new build warnings with this patch:
During meson setup:
libpurple/protocols/ircv3/meson.build:55: WARNING: Project targets '>=0.58.0' but uses feature introduced in '0.60.0': list.<plus>. The right hand operand was not a list.During build:
(introspectable:14205): GLib-GObject-WARNING **: 07:27:34.572: ../../../gobject/gtypemodule.c:104: unsolicitated invocation of g_object_run_dispose() on GTypeModule (ircv3generategir:15878): Purple-CRITICAL **: 07:27:41.670: purple_account_manager_foreach: assertion 'PURPLE_IS_ACCOUNT_MANAGER(manager)' failed (ircv3generategir:15878): GLib-CRITICAL **: 07:27:41.670: g_hash_table_foreach: assertion 'hash_table != NULL' failed (ircv3generategir:15878): GLib-CRITICAL **: 07:27:41.670: g_hash_table_remove_internal: assertion 'hash_table != NULL' failed (ircv3generategir:15878): GLib-GObject-WARNING **: 07:27:41.670: ../../../gobject/gtypemodule.c:104: unsolicitated invocation of g_object_run_dispose() on GTypeModule -
subprojects/gplugin.wrap (Diff revision 2) The version needs to updated in the top level meson.build as well.
Change Summary:
Address issues. There's on more list + string thing, but that's unrelated so I'll open another rr for that.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+436 -54) |