Create gobject-introspection to make native plugins introspectable

Review Request #2458 — Created June 2, 2023 and submitted

Information

gplugin/gplugin
default

Reviewers

There's a lot to this, but the documentation covers the consumer side. From
the GPlugin developer side, we basically created static library that manually
loads plugins and is setup in a way to be called via g-ir-scanner's --program
argument.

Ran the new unit tests that test gir generation. Also installed to a local prefix and used that to compile a binary against gplugin-introspection and verified it displayed the proper output for --help.

Summary ID
Create gobject-introspection to make native plugins introspectable
There's a lot to this, but the documentation covers the consumer side. From the GPlugin developer side, we basically created static library that manually loads plugins and is setup in a way to be called via g-ir-scanner's --program argument.
afd7944332ce17091f84962bf6ff56b426595ab4
Description From Last Updated

g_set_error_literal, I guess.

QuLogicQuLogic

irdump is not freed at the end, and though that doesn't matter very much, it is done on every early …

QuLogicQuLogic

provided

QuLogicQuLogic

Similarly not freed in the successful case (and likely similarly not too important.)

QuLogicQuLogic

Isn't this case already handled in gplugin_introspection_query_and_load_plugin?

QuLogicQuLogic

Maybe a bit contradictory message; if it's NULL, then that'd be printed twice, but if it's non-NULL, then the message …

QuLogicQuLogic

Unused?

QuLogicQuLogic
QuLogic
  1. 
      
  2. Show all issues

    g_set_error_literal, I guess.

  3. Show all issues

    irdump is not freed at the end, and though that doesn't matter very much, it is done on every early return.

  4. Show all issues

    provided

  5. Show all issues

    Similarly not freed in the successful case (and likely similarly not too important.)

  6. Show all issues

    Isn't this case already handled in gplugin_introspection_query_and_load_plugin?

  7. Show all issues

    Maybe a bit contradictory message; if it's NULL, then that'd be printed twice, but if it's non-NULL, then the message is wrong.

    1. I think this was for debugging and should probably just be deleted.

  8. gplugin-introspection/tests/meson.build (Diff revision 1)
     
     
    Show all issues

    Unused?

  9. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed