Summary

Create gobject-introspection to make native plugins introspectable

Review Request #2458 — Created June 3, 2023 and submitted June 14, 2023, 2:26 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

There's a lot to this, but the documentation covers the consumer side. From
the GPlugin developer side, we basically created static library that manually
loads plugins and is setup in a way to be called via g-ir-scanner's --program
argument.

Testing Done

Ran the new unit tests that test gir generation. Also installed to a local prefix and used that to compile a binary against gplugin-introspection and verified it displayed the proper output for --help.

Commits

Summary	ID
Create gobject-introspection to make native plugins introspectable There's a lot to this, but the documentation covers the consumer side. From the GPlugin developer side, we basically created static library that manually loads plugins and is setup in a way to be called via g-ir-scanner's --program argument.	afd7944332ce17091f84962bf6ff56b426595ab4

Issues

Description	From	Last Updated
g_set_error_literal, I guess.	QuLogic	June 13, 2023, 10:16 p.m.
irdump is not freed at the end, and though that doesn't matter very much, it is done on every early …	QuLogic	June 13, 2023, 10:15 p.m.
provided	QuLogic	June 13, 2023, 10:16 p.m.
Similarly not freed in the successful case (and likely similarly not too important.)	QuLogic	June 13, 2023, 10:15 p.m.
Isn't this case already handled in gplugin_introspection_query_and_load_plugin?	QuLogic	June 13, 2023, 10:15 p.m.
Maybe a bit contradictory message; if it's NULL, then that'd be printed twice, but if it's non-NULL, then the message …	QuLogic	June 13, 2023, 10:15 p.m.
Unused?	QuLogic	June 13, 2023, 10:15 p.m.

gplugin-introspection/gplugin-introspection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
g_set_error_literal, I guess.
```

gplugin-introspection/gplugin-introspection.c (Diff revision 1)

The issue has been resolved. Show all issues

irdump is not freed at the end, and though that doesn't matter very much, it is done on every early return.

gplugin-introspection/gplugin-introspection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
provided
```
gplugin-introspection/gplugin-introspection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Similarly not freed in the successful case (and likely similarly not too important.)
```
gplugin-introspection/gplugin-introspection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Isn't this case already handled in gplugin_introspection_query_and_load_plugin?
```
1. grim June 13, 2023, 8:20 a.m.
  Nice find!

gplugin-introspection/gplugin-introspection.c (Diff revision 1)

The issue has been resolved. Show all issues

Maybe a bit contradictory message; if it's NULL, then that'd be printed twice, but if it's non-NULL, then the message is wrong.

grim June 13, 2023, 8:20 a.m.

I think this was for debugging and should probably just be deleted.

gplugin-introspection/tests/meson.build (Diff revision 1)
The issue has been resolved. Show all issues
```
Unused?
```

Change Summary:

Address issues

Commits:

	Summary	ID
	Create gobject-introspection to make native plugins introspectable There's a lot to this, but the documentation covers the consumer side. From the GPlugin developer side, we basically created static library that manually loads plugins and is setup in a way to be called via g-ir-scanner's --program argument.	950e2ac5497e3300ff61a7512c572ed8cb7d626b
	Create gobject-introspection to make native plugins introspectable There's a lot to this, but the documentation covers the consumer side. From the GPlugin developer side, we basically created static library that manually loads plugins and is setup in a way to be called via g-ir-scanner's --program argument.	afd7944332ce17091f84962bf6ff56b426595ab4

Diff:

Revision 2 (+1390 -2)

Show changes

	meson.build
	gplugin/gplugin-native-plugin.h
	gplugin-introspection/gplugin-introspection.h
	gplugin-introspection/gplugin-introspection.c
	gplugin-introspection/meson.build
	gplugin-introspection/tests/generate.c
	gplugin-introspection/tests/introspectablecore.c
	gplugin-introspection/tests/introspectabletype.h
	5 more

Ship it!

```
Ship It!
```

Status:: Completed