Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+18 -34) |
Use Alpine for Dockerfile
Review Request #2454 — Created May 12, 2023 and updated
Information | |
---|---|
aklitzing@gmail.com | |
grim/hgkeeper | |
default | |
Reviewers | |
grim |
Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.
Summary | Author | |
---|---|---|
Andre Klitzing |
Description | From | Last Updated |
---|---|---|
I'd rather we lock this down to 3.18 or even 3 just to avoid major updates. |
|
|
In scripts, including stuff like dockerfiles, I prefer if we use the long arguments. They're usually self explanatory and don't … |
|
|
should be 2 lines and rm -rf /var/cache/apk is a bit safer. |
|
-
-
Dockerfile (Diff revision 2) I'd rather we lock this down to 3.18 or even 3 just to avoid major updates.
-
Dockerfile (Diff revision 2) In scripts, including stuff like dockerfiles, I prefer if we use the long arguments. They're usually self explanatory and don't require lookup and are only typed once so theres no reason to take a shortcut.
Also you're telling it to not use a cache but to also update a cache, that seems wrong espeically since the other adds aren't using the cache either.
Preferrably this should just use
--update-cache
in upgrade which is run first (although I'm not sure why this is even necessary, alpine images aren't usually more than a day behind), remove all the--no-caches
, and finally manually delete the cache at the end of the run.
Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+20 -36) |
Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+22 -36) |