Use Alpine for Dockerfile

Review Request #2454 — Created May 12, 2023 and submitted

Information

grim/hgkeeper
default

Reviewers

Also use mercurial from Alpine repository as it is up-to-date and enables
rust extensions and chg binary.

This decreases the size of docker image.

 
Summary ID Author
Use Alpine for Dockerfile
Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.
00858d2bede6e429a5c368c6151f694c5cfc8e10 Andre Klitzing
Description From Last Updated

I'd rather we lock this down to 3.18 or even 3 just to avoid major updates.

grimgrim

In scripts, including stuff like dockerfiles, I prefer if we use the long arguments. They're usually self explanatory and don't …

grimgrim

should be 2 lines and rm -rf /var/cache/apk is a bit safer.

grimgrim
aklitzing@gmail.com
grim
  1. 
      
  2. Dockerfile (Diff revision 2)
     
     
    Show all issues

    I'd rather we lock this down to 3.18 or even 3 just to avoid major updates.

  3. Dockerfile (Diff revision 2)
     
     
    Show all issues

    In scripts, including stuff like dockerfiles, I prefer if we use the long arguments. They're usually self explanatory and don't require lookup and are only typed once so theres no reason to take a shortcut.

    Also you're telling it to not use a cache but to also update a cache, that seems wrong espeically since the other adds aren't using the cache either.

    Preferrably this should just use --update-cache in upgrade which is run first (although I'm not sure why this is even necessary, alpine images aren't usually more than a day behind), remove all the --no-caches, and finally manually delete the cache at the end of the run.

  4. 
      
aklitzing@gmail.com
grim
  1. 
      
  2. Dockerfile (Diff revisions 2 - 3)
     
     
    Show all issues

    should be 2 lines and rm -rf /var/cache/apk is a bit safer.

  3. 
      
aklitzing@gmail.com
grim
  1. Ship It!
  2. Great work! Thanks!!

  3. 
      
grim
Review request changed
Status:
Completed