Summary

Use Alpine for Dockerfile

Review Request #2454 — Created May 12, 2023 and submitted June 14, 2023, 8:44 a.m.

Information

Owner

aklitzing@gmail.com

Repository

grim/hgkeeper

Branch

default

Bugs

Depends On

Reviewers

Groups

People

grim

Description

Also use mercurial from Alpine repository as it is up-to-date and enables
rust extensions and chg binary.

This decreases the size of docker image.

Testing Done

Commits

Summary	ID	Author
Use Alpine for Dockerfile Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.	00858d2bede6e429a5c368c6151f694c5cfc8e10	Andre Klitzing

Issues

Description	From	Last Updated
I'd rather we lock this down to 3.18 or even 3 just to avoid major updates.	grim	May 24, 2023, 8:13 p.m.
In scripts, including stuff like dockerfiles, I prefer if we use the long arguments. They're usually self explanatory and don't …	grim	May 24, 2023, 8:13 p.m.
should be 2 lines and rm -rf /var/cache/apk is a bit safer.	grim	May 24, 2023, 8:25 p.m.

Commits:

	Summary	ID	Author
	Use Alpine for Dockerfile Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.	d6ff240f16502947a3468561f5fbb832118de55c	Andre Klitzing
	Use Alpine for Dockerfile Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.	7364afc5fbc8c73bdeaef024298c88585ab2c174	Andre Klitzing

Diff:

Revision 2 (+18 -34)

Show changes

Dockerfile

Dockerfile (Diff revision 2)

Show all issues

I'd rather we lock this down to 3.18 or even 3 just to avoid major updates.

Dockerfile (Diff revision 2)

Show all issues

In scripts, including stuff like dockerfiles, I prefer if we use the long arguments. They're usually self explanatory and don't require lookup and are only typed once so theres no reason to take a shortcut.

Also you're telling it to not use a cache but to also update a cache, that seems wrong espeically since the other adds aren't using the cache either.

Preferrably this should just use --update-cache in upgrade which is run first (although I'm not sure why this is even necessary, alpine images aren't usually more than a day behind), remove all the --no-caches, and finally manually delete the cache at the end of the run.

Commits:

	Summary	ID	Author
	Use Alpine for Dockerfile Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.	7364afc5fbc8c73bdeaef024298c88585ab2c174	Andre Klitzing
	Use Alpine for Dockerfile Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.	7e116596e55dadc9dd0ffe02321b9bf4a80c4145	Andre Klitzing

Diff:

Revision 3 (+20 -36)

Show changes

	.dockerignore
	Dockerfile

Dockerfile (Diff revisions 2 - 3)

Show all issues

should be 2 lines and rm -rf /var/cache/apk is a bit safer.

Commits:

	Summary	ID	Author
	Use Alpine for Dockerfile Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.	7e116596e55dadc9dd0ffe02321b9bf4a80c4145	Andre Klitzing
	Use Alpine for Dockerfile Also use mercurial from Alpine repository as it is up-to-date and enables rust extensions and chg binary. This decreases the size of docker image.	00858d2bede6e429a5c368c6151f694c5cfc8e10	Andre Klitzing

Diff:

Revision 4 (+22 -36)

Show changes

	.dockerignore
	Dockerfile

Ship it!

```
Ship It!
```
```
Great work! Thanks!!
```

Review Board 6.0.2

Use Alpine for Dockerfile

Information

Reviewers

Commits:

Diff:

Commits:

Diff:

Commits:

Diff:

Status: Closed (submitted)