Don't duplicate contacts in the demo protocol when reconnecting

Review Request #2436 — Created April 12, 2023 and submitted

grim
pidgin/pidgin
default
pidgin

Previously, we were always creating new contacts and persons on connection. This
ends up with duplicates when we run the connection error actions which is
obviously not what we want.

Ran the connection error actions and verified that we did not get duplicate contacts and persons.

Summary
Don't duplicate contacts in the demo protocol when reconnecting
Description From Last Updated

contact leaks if it's not new.

QuLogicQuLogic

Actually, I think the purple_contact_manager_add annotation might be wrong and it leaks in both cases.

QuLogicQuLogic
QuLogic
QuLogic
  1. 
      
  2. libpurple/protocols/demo/purpledemocontacts.c (Diff revision 1)
     
     
     
     
     

    contact leaks if it's not new.

  3. Actually, I think the purple_contact_manager_add annotation might be wrong and it leaks in both cases.

    1. Oh, it's not wrong; it says transfer none, so this side leaks too.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...