Summary

Don't duplicate contacts in the demo protocol when reconnecting

Review Request #2436 — Created April 12, 2023 and submitted April 19, 2023, 2:21 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Previously, we were always creating new contacts and persons on connection. This
ends up with duplicates when we run the connection error actions which is
obviously not what we want.

Testing Done

Ran the connection error actions and verified that we did not get duplicate contacts and persons.

Commits

Summary	ID
Don't duplicate contacts in the demo protocol when reconnecting Perviously we were always creating new contacts and persons on connection. This ends up with duplicates when we run the connection error actions which is obviously not what we want.	daafd9a2402b1b89bac760cecd2d1210a67afea5

Issues

Description	From	Last Updated
contact leaks if it's not new.	QuLogic	April 19, 2023, 2:13 a.m.
Actually, I think the purple_contact_manager_add annotation might be wrong and it leaks in both cases.	QuLogic	April 19, 2023, 2:13 a.m.

Change Summary:: Fix typo.
Description:: ~
Perviously we were always creating new contacts and persons on connection. This
~
Previously, we were always creating new contacts and persons on connection. This
ends up with duplicates when we run the connection error actions which is
obviously not what we want.

libpurple/protocols/demo/purpledemocontacts.c (Diff revision 1)
The issue has been resolved. Show all issues
```
contact leaks if it's not new.
```

libpurple/protocols/demo/purpledemocontacts.c (Diff revision 1)

The issue has been resolved. Show all issues

Actually, I think the purple_contact_manager_add annotation might be wrong and it leaks in both cases.

QuLogic April 17, 2023, 8:14 a.m.

Oh, it's not wrong; it says transfer none, so this side leaks too.

Change Summary:

always clear the contact after adding it to the manager as we're done with it.

Commits:

	Summary	ID
	Don't duplicate contacts in the demo protocol when reconnecting Perviously we were always creating new contacts and persons on connection. This ends up with duplicates when we run the connection error actions which is obviously not what we want.	a3a9a9b130c40bec3a5d1caf13d3f8ae12af43f6
	Don't duplicate contacts in the demo protocol when reconnecting Perviously we were always creating new contacts and persons on connection. This ends up with duplicates when we run the connection error actions which is obviously not what we want.	daafd9a2402b1b89bac760cecd2d1210a67afea5

Diff:

Revision 2 (+98 -18)

Show changes

libpurple/protocols/demo/purpledemocontacts.c

Ship it!

```
Ship It!
```

Status:: Completed

~		Perviously we were always creating new contacts and persons on connection. This
	~	Previously, we were always creating new contacts and persons on connection. This
		ends up with duplicates when we run the connection error actions which is
		obviously not what we want.