- Download Diff

Summary:

Introduce "rm <repo>" command

Review Request #2421 — Created April 4, 2023 and submitted April 12, 2023, 11:58 p.m.

Information
Owner:	aklitzing@gmail.com
Repository:	grim/hgkeeper
Branch:	default
Bugs:	HGKEEPER-25
Depends On:	~~2434~~
Blocks:	2422
Reviewers
Groups:
People:	grim

Description

It is possible to create a new repository with "hg init" but it is not possible
to remove any repositories. So let's use "ssh command" to allow this.

$ ssh hg.host.com rm repoName

Testing Done

Commits

Summary		Author
	Introduce "rm <repo>" command	Andre Klitzing

Screenshots

Issues

Description	From	Last Updated
I'm not sure I like this being enabled by default as it'd be super easy to accidentally remove the wrong …	grim	April 11, 2023, 9:37 p.m.
This is from another review request	grim	April 12, 2023, 5:17 p.m.
This is also from another review request.	grim	April 12, 2023, 5:17 p.m.

Commits:

	Summary		Author
-		Introduce "rm <repo>" command	Andre Klitzing
+		Introduce "rm <repo>" command	Andre Klitzing

Depends On:

+	~~2422 - Deny invalid path~~

Diff:

Revision 2 (+176 -2)

Show changes

	access/access.go
	access/hgweb.go
	hg/parser.go
	setup/resources/policy.csv.template
	ssh/commands/commands.go
	ssh/commands/rm.go

Commits:

	Summary		Author
-		Introduce "rm <repo>" command	Andre Klitzing
+		Introduce "rm <repo>" command	Andre Klitzing

Diff:

Revision 3 (+176 -2)

Show changes

	access/access.go
	access/hgweb.go
	hg/parser.go
	setup/resources/policy.csv.template
	ssh/commands/commands.go
	ssh/commands/rm.go

Bugs:

+	HGKEEPER-25

Show all issues

I'm not sure I like this being enabled by default as it'd be super easy to accidentally remove the wrong repo with a typo. I think I'd much rather see a command line flag or something that enables this as a feature.

I'm also not really a fan of adding another access level. That said, I think using the init level for now is probably fine with the intent to rename that (with backwards compatibility) to admin.

Thoughts?

aklitzing@gmail.com April 10, 2023, 5:48 p.m.

Yeah, I understand that "remove" should be explicitly enabled. But I don't see another flag for this. I just commented out the "predefined policy". That should be enough for the "flag". :-)

Yes, I had the same idea to re-use "init" for this. But I want to allow any user to create repositories. That would allow any user to remove repos.... well, no, that is not a good idea to do that. :-)
init and remove should be separated and disabled by default.

Commits:

	Summary		Author
-		Introduce "rm <repo>" command	Andre Klitzing
+		Introduce "rm <repo>" command	Andre Klitzing

Diff:

Revision 4 (+174)

Show changes

	access/access.go
	access/hgweb.go
	hg/parser.go
	setup/resources/policy.csv.template
	ssh/commands/commands.go
	ssh/commands/rm.go

access/access.go (Diff revisions 3 - 4)

this is from another review request...

setup/resources/policy.csv.template (Diff revisions 3 - 4)
```
This looks good!
```

access/access.go (Diff revision 4)
Show all issues
```
This is from another review request
```

access/access.go (Diff revision 4)

Show all issues

This is also from another review request.

Commits:

	Summary		Author
-		Introduce "rm <repo>" command	Andre Klitzing
+		Introduce "rm <repo>" command	Andre Klitzing

Depends On:

-	~~2422 - Deny invalid path~~
+	~~2434 - Refactor refresh of repositories~~

Diff:

Revision 5 (+166)

Show changes

	access/access.go
	access/repositories.go
	hg/parser.go
	setup/resources/policy.csv.template
	ssh/commands/commands.go
	ssh/commands/rm.go

Ship it!

```
Ship It!
```
```
Nice work! Thanks!!
```

You have a pending review.

Review Board 5.0.4

Introduce "rm <repo>" command

Commits:

Depends On:

Diff:

Commits:

Diff:

Bugs:

Commits:

Diff:

Commits:

Depends On:

Diff:

Status: Closed (submitted)