Introduce "rm <repo>" command

Review Request #2421 — Created April 4, 2023 and submitted

Information

grim/hgkeeper
default

Reviewers

It is possible to create a new repository with "hg init" but it is not possible
to remove any repositories. So let's use "ssh command" to allow this.

$ ssh hg.host.com rm repoName

 
Summary ID Author
Introduce "rm <repo>" command
It is possible to create a new repository with "hg init" but it is not possible to remove any repositories. So let's use "ssh command" to allow this. $ ssh hg.host.com rm repoName
89d1b71af78fde1f6f70f48912d802610b7a15fb Andre Klitzing
Description From Last Updated

I'm not sure I like this being enabled by default as it'd be super easy to accidentally remove the wrong …

grimgrim

This is from another review request

grimgrim

This is also from another review request.

grimgrim
aklitzing@gmail.com
aklitzing@gmail.com
aklitzing@gmail.com
grim
  1. 
      
  2. Show all issues

    I'm not sure I like this being enabled by default as it'd be super easy to accidentally remove the wrong repo with a typo. I think I'd much rather see a command line flag or something that enables this as a feature.

    I'm also not really a fan of adding another access level. That said, I think using the init level for now is probably fine with the intent to rename that (with backwards compatibility) to admin.

    Thoughts?

    1. Yeah, I understand that "remove" should be explicitly enabled. But I don't see another flag for this. I just commented out the "predefined policy". That should be enough for the "flag". :-)

      Yes, I had the same idea to re-use "init" for this. But I want to allow any user to create repositories. That would allow any user to remove repos.... well, no, that is not a good idea to do that. :-)
      init and remove should be separated and disabled by default.

  3. 
      
aklitzing@gmail.com
grim
  1. 
      
  2. access/access.go (Diff revisions 3 - 4)
     
     

    this is from another review request...

  3. setup/resources/policy.csv.template (Diff revisions 3 - 4)
     
     

    This looks good!

  4. 
      
grim
  1. 
      
  2. access/access.go (Diff revision 4)
     
     
    Show all issues

    This is from another review request

  3. access/access.go (Diff revision 4)
     
     
    Show all issues

    This is also from another review request.

  4. 
      
aklitzing@gmail.com
grim
  1. Ship It!
  2. Nice work! Thanks!!

  3. 
      
grim
Review request changed
Status:
Completed