Summary

Clean up Finch preferences page

Review Request #2416 — Created April 3, 2023 and submitted April 3, 2023, 3:03 p.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Instead of mixing two strings into a GList, use a PurpleKeyValuePair.

Use struct initializers and G_N_ELEMENTS.

Rename lv to choices for clarity.

Change from PurpleRequestFieldList to PurpleRequestFieldChoice as we don't need multiple selection.

Testing Done

Opened Finch, opened Preferences, saved them, and exited Finch. Re-opened Prefs and confirmed they were saved and as expected.

Commits

Summary	ID
Cleanup Finch preferences page	6938ed9d8cc9fc017cd1fda7c8a80ccb586217a0

Change Summary:

Change from PurpleRequestFieldList to PurpleRequestFieldChoice.

Description:

		Instead of mixing two strings into a `GList`, use a `PurpleKeyValuePair`.
		Use struct initializers and `G_N_ELEMENTS`.
~		Rename `lv` to `choices` for clarity.
	~	Rename `lv` to `choices` for clarity.
	+	Change from `PurpleRequestFieldList` to `PurpleRequestFieldChoice` as we don't need multiple selection.

Testing Done:

~		Opened Finch, opened Preferences, saved them, and exited Finch.
	~	Opened Finch, opened Preferences, saved them, and exited Finch. Re-opened Prefs and confirmed they were saved and as expected.

Commits:

	Summary	ID
	Cleanup Finch preferences page	2889d9344b8f7ad5f09d3b9985707db475a2155a
	Cleanup Finch preferences page	6938ed9d8cc9fc017cd1fda7c8a80ccb586217a0

Diff:

Revision 2 (+290 -186)

Show changes

	finch/gntprefs.c
	finch/gntrequest.c

Ship it!

```
Ship It!
```
```
Nice work, thanks!!
```

Status:: Completed