Change Summary:
Change from
PurpleRequestFieldList
toPurpleRequestFieldChoice
.
Description: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||
Commits: |
|
|||||||||||||||
Diff: |
Revision 2 (+290 -186) |
Review Request #2416 — Created April 3, 2023 and submitted
Information | |
---|---|
QuLogic | |
pidgin/pidgin | |
default | |
Reviewers | |
pidgin | |
Instead of mixing two strings into a
GList
, use aPurpleKeyValuePair
.
Use struct initializers andG_N_ELEMENTS
.
Renamelv
tochoices
for clarity.
Change fromPurpleRequestFieldList
toPurpleRequestFieldChoice
as we don't need multiple selection.
Opened Finch, opened Preferences, saved them, and exited Finch. Re-opened Prefs and confirmed they were saved and as expected.
Summary |
---|
Change from
PurpleRequestFieldList
toPurpleRequestFieldChoice
.
Description: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||
Commits: |
|
|||||||||||||||
Diff: |
Revision 2 (+290 -186) |