Port VV preferences from GtkComboBox to AdwComboRow

Review Request #2398 — Created March 31, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This removes another GtkComboBox and fixes the requested width of the row, so the label no longers gets squashed when you have a long device name.

Opened Prefs, selected a different Audio Input, and confirmed it was saved/restored when re-opening.
Ran Test Audio and confirmed input was coming from the right input.
Disconnected an audio device and confirmed that the list re-populated correctly.
Disconnected the selected audio device and confirmed that the selection dropped back to Default.
Ran Test Audio, disconnected the selected audio device and confirmed the audio pipeline switched to Default device.

Summary ID
Port VV preferences from GtkComboBox to AdwComboRow
6e77d687804c488be84417ce515586be891dc0b4
Description From Last Updated

indent looks weird.

grimgrim
grim
  1. 
      
  2. pidgin/prefs/pidginvvprefs.c (Diff revision 1)
     
     
    Show all issues

    indent looks weird.

    1. It's because all the casts at the beginning of the previous line are really wide so the arguments would be over 80 characters already. (Also, this is only a variable rename, no change to indent.)

  3. 
      
QuLogic
grim
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed