Summary

Port VV preferences from GtkComboBox to AdwComboRow

Review Request #2398 — Created March 30, 2023 and submitted March 30, 2023, 10:31 p.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2406

Reviewers

Groups

pidgin

People

Description

This removes another GtkComboBox and fixes the requested width of the row, so the label no longers gets squashed when you have a long device name.

Testing Done

Opened Prefs, selected a different Audio Input, and confirmed it was saved/restored when re-opening.
Ran Test Audio and confirmed input was coming from the right input.
Disconnected an audio device and confirmed that the list re-populated correctly.
Disconnected the selected audio device and confirmed that the selection dropped back to Default.
Ran Test Audio, disconnected the selected audio device and confirmed the audio pipeline switched to Default device.

Commits

Summary	ID
Port VV preferences from GtkComboBox to AdwComboRow	6e77d687804c488be84417ce515586be891dc0b4

Issues

Description	From	Last Updated
indent looks weird.	grim	March 30, 2023, 10:27 p.m.

pidgin/prefs/pidginvvprefs.c (Diff revision 1)

The issue has been resolved. Show all issues

indent looks weird.

QuLogic March 30, 2023, 10:06 p.m.

It's because all the casts at the beginning of the previous line are really wide so the arguments would be over 80 characters already. (Also, this is only a variable rename, no change to indent.)

Change Summary:

Fix indent.

Commits:

	Summary	ID
	Port VV preferences from GtkComboBox to AdwComboRow	5fcf2284f078d8a5fadeba67505dd022cbd2a3d6
	Port VV preferences from GtkComboBox to AdwComboRow	6e77d687804c488be84417ce515586be891dc0b4

Diff:

Revision 2 (+262 -312)

Show changes

	pidgin/prefs/pidginvvprefs.c
	pidgin/resources/Prefs/vv.ui

Ship it!

```
Ship It!
```

Status:: Completed