Summary

Add "new-status" properties to PurplePresence with fallbacks were applicable

Review Request #2372 — Created March 21, 2023 and submitted March 21, 2023, 7:37 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2376

Reviewers

Groups

pidgin

People

Description

This adds the new emoji and mobile properties to PurplePresence. It also makes message read/write and it fallsback to the active status's message if the internal message is false. Additionally the primitive property was moved PurpleStatusPrimitive to PurplePresencePrimitive.

Testing Done

Ran the updated unit tests and connected a demo account and verified that the expected status messages were displayed.

Commits

Summary	ID
Make PurplePresence:message read/write but fallback to the active status's message if it's unset This allows us to start transitioning protocols while keeping the existing functionality.	b573ac55feab22fdb779afce9b6f19fc031246b2

Summary:

-	Make PurplePresence:message read/write but fallback to the active status's message if it's unset
+	Add "new-status" properties to PurplePresence with fallbacks were applicable

Description:

~		This allows us to start transitioning protocols while keeping the existing
	~	This adds the new `emoji` and `mobile` properties to `PurplePresence`. It also makes `message` read/write and it fallsback to the active status's message if the internal message is false. Additionally the primitive property was moved `PurpleStatusPrimitive` to `PurplePresencePrimitive`.
-		functionality.

Testing Done:

~		Connected a demo account and verified that the expected status messages were displayed.
	~	Ran the updated unit tests and connected a demo account and verified that the expected status messages were displayed.

Commits:

	Summary	ID
	Make PurplePresence:message read/write but fallback to the active status's message if it's unset This allows us to start transitioning protocols while keeping the existing functionality.	8751668c79d9cad298a03c91ecf668e4cfd2bca7
	Make PurplePresence:message read/write but fallback to the active status's message if it's unset This allows us to start transitioning protocols while keeping the existing functionality.	e302e465b122ea8a8c062098a3b6811eef8b0b57

Diff:

Revision 2 (+562 -128)

Show changes

	libpurple/purplepresence.h
	libpurple/purplepresence.c
	libpurple/tests/test_presence.c

Change Summary:

Rebased

Commits:

	Summary	ID
	Make PurplePresence:message read/write but fallback to the active status's message if it's unset This allows us to start transitioning protocols while keeping the existing functionality.	e302e465b122ea8a8c062098a3b6811eef8b0b57
	Make PurplePresence:message read/write but fallback to the active status's message if it's unset This allows us to start transitioning protocols while keeping the existing functionality.	b573ac55feab22fdb779afce9b6f19fc031246b2

Diff:

Revision 3 (+562 -128)

Show changes

	libpurple/purplepresence.h
	libpurple/purplepresence.c
	libpurple/tests/test_presence.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add "new-status" properties to PurplePresence with fallbacks were applicable

Information

Reviewers

Summary:

Description:

Testing Done:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)